Re: [PATCH 04/15] Platform: OLPC: Remove an unused include

2018-11-13 Thread Lubomir Rintel
Hi, thank you for the response. On Fri, 2018-10-19 at 16:05 +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel > wrote: > > Also, the header is x86 specific, while there are non-x86 OLPC > > machines. > > Same concern. as per patch 2. Which concern? If it's that it

Re: [PATCH 04/15] Platform: OLPC: Remove an unused include

2018-11-13 Thread Lubomir Rintel
Hi, thank you for the response. On Fri, 2018-10-19 at 16:05 +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel > wrote: > > Also, the header is x86 specific, while there are non-x86 OLPC > > machines. > > Same concern. as per patch 2. Which concern? If it's that it

Re: [PATCH 04/15] Platform: OLPC: Remove an unused include

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:22:49, Lubomir Rintel wrote: > Also, the header is x86 specific, while there are non-x86 OLPC machines. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > --- > drivers/platform/olpc/olpc-ec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH 04/15] Platform: OLPC: Remove an unused include

2018-11-04 Thread Pavel Machek
On Wed 2018-10-10 19:22:49, Lubomir Rintel wrote: > Also, the header is x86 specific, while there are non-x86 OLPC machines. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > --- > drivers/platform/olpc/olpc-ec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH 04/15] Platform: OLPC: Remove an unused include

2018-10-19 Thread Andy Shevchenko
On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote: > > Also, the header is x86 specific, while there are non-x86 OLPC machines. Same concern. as per patch 2. Also, you might want to sort headers in alphabetical order. > > Signed-off-by: Lubomir Rintel > --- >

Re: [PATCH 04/15] Platform: OLPC: Remove an unused include

2018-10-19 Thread Andy Shevchenko
On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote: > > Also, the header is x86 specific, while there are non-x86 OLPC machines. Same concern. as per patch 2. Also, you might want to sort headers in alphabetical order. > > Signed-off-by: Lubomir Rintel > --- >

[PATCH 04/15] Platform: OLPC: Remove an unused include

2018-10-10 Thread Lubomir Rintel
Also, the header is x86 specific, while there are non-x86 OLPC machines. Signed-off-by: Lubomir Rintel --- drivers/platform/olpc/olpc-ec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c index f99b183d5296..35a21c66cd0d 100644

[PATCH 04/15] Platform: OLPC: Remove an unused include

2018-10-10 Thread Lubomir Rintel
Also, the header is x86 specific, while there are non-x86 OLPC machines. Signed-off-by: Lubomir Rintel --- drivers/platform/olpc/olpc-ec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c index f99b183d5296..35a21c66cd0d 100644