Re: [PATCH 04/15] mm/hmm: unregister mmu_notifier when last HMM client quit v2

2018-03-22 Thread John Hubbard
On 03/22/2018 05:50 PM, Jerome Glisse wrote: > On Thu, Mar 22, 2018 at 05:13:14PM -0700, John Hubbard wrote: >> On 03/22/2018 04:37 PM, Jerome Glisse wrote: >>> On Thu, Mar 22, 2018 at 03:47:16PM -0700, John Hubbard wrote: On 03/21/2018 04:41 PM, Jerome Glisse wrote: > On Wed, Mar 21, 2018

Re: [PATCH 04/15] mm/hmm: unregister mmu_notifier when last HMM client quit v2

2018-03-22 Thread Jerome Glisse
On Thu, Mar 22, 2018 at 05:13:14PM -0700, John Hubbard wrote: > On 03/22/2018 04:37 PM, Jerome Glisse wrote: > > On Thu, Mar 22, 2018 at 03:47:16PM -0700, John Hubbard wrote: > >> On 03/21/2018 04:41 PM, Jerome Glisse wrote: > >>> On Wed, Mar 21, 2018 at 04:22:49PM -0700, John Hubbard wrote: >

Re: [PATCH 04/15] mm/hmm: unregister mmu_notifier when last HMM client quit v2

2018-03-22 Thread John Hubbard
On 03/22/2018 04:37 PM, Jerome Glisse wrote: > On Thu, Mar 22, 2018 at 03:47:16PM -0700, John Hubbard wrote: >> On 03/21/2018 04:41 PM, Jerome Glisse wrote: >>> On Wed, Mar 21, 2018 at 04:22:49PM -0700, John Hubbard wrote: On 03/21/2018 11:16 AM, jgli...@redhat.com wrote: > From: Jérôme Gl

Re: [PATCH 04/15] mm/hmm: unregister mmu_notifier when last HMM client quit v2

2018-03-22 Thread Jerome Glisse
On Thu, Mar 22, 2018 at 03:47:16PM -0700, John Hubbard wrote: > On 03/21/2018 04:41 PM, Jerome Glisse wrote: > > On Wed, Mar 21, 2018 at 04:22:49PM -0700, John Hubbard wrote: > >> On 03/21/2018 11:16 AM, jgli...@redhat.com wrote: > >>> From: Jérôme Glisse > >>> > >>> This code was lost in translat

Re: [PATCH 04/15] mm/hmm: unregister mmu_notifier when last HMM client quit v2

2018-03-22 Thread John Hubbard
On 03/21/2018 04:41 PM, Jerome Glisse wrote: > On Wed, Mar 21, 2018 at 04:22:49PM -0700, John Hubbard wrote: >> On 03/21/2018 11:16 AM, jgli...@redhat.com wrote: >>> From: Jérôme Glisse >>> >>> This code was lost in translation at one point. This properly call >>> mmu_notifier_unregister_no_releas

Re: [PATCH 04/15] mm/hmm: unregister mmu_notifier when last HMM client quit v2

2018-03-21 Thread Jerome Glisse
On Wed, Mar 21, 2018 at 04:22:49PM -0700, John Hubbard wrote: > On 03/21/2018 11:16 AM, jgli...@redhat.com wrote: > > From: Jérôme Glisse > > > > This code was lost in translation at one point. This properly call > > mmu_notifier_unregister_no_release() once last user is gone. This > > fix the zo

Re: [PATCH 04/15] mm/hmm: unregister mmu_notifier when last HMM client quit v2

2018-03-21 Thread John Hubbard
On 03/21/2018 11:16 AM, jgli...@redhat.com wrote: > From: Jérôme Glisse > > This code was lost in translation at one point. This properly call > mmu_notifier_unregister_no_release() once last user is gone. This > fix the zombie mm_struct as without this patch we do not drop the > refcount we have

[PATCH 04/15] mm/hmm: unregister mmu_notifier when last HMM client quit v2

2018-03-21 Thread jglisse
From: Jérôme Glisse This code was lost in translation at one point. This properly call mmu_notifier_unregister_no_release() once last user is gone. This fix the zombie mm_struct as without this patch we do not drop the refcount we have on it. Changed since v1: - close race window between a las