Re: [PATCH 04/16] printk: implement support for extended console drivers

2015-04-28 Thread Petr Mladek
On Tue 2015-04-28 10:10:14, Tejun Heo wrote: > Hello, Petr. > > On Tue, Apr 28, 2015 at 11:42:44AM +0200, Petr Mladek wrote: > > Note that cont buffer is only a memory optimization. You could put > > every text snippet into the ring buffer and console immediately. > > You need to set LOG_CONT inst

Re: [PATCH 04/16] printk: implement support for extended console drivers

2015-04-28 Thread Tejun Heo
Hello, Petr. On Tue, Apr 28, 2015 at 11:42:44AM +0200, Petr Mladek wrote: > Note that cont buffer is only a memory optimization. You could put > every text snippet into the ring buffer and console immediately. > You need to set LOG_CONT instead of LOG_NEWLINE flag. This is > already used when the

Re: [PATCH 04/16] printk: implement support for extended console drivers

2015-04-28 Thread Petr Mladek
On Mon 2015-04-27 17:09:22, Tejun Heo wrote: > Hello, Petr. > > Sorry about the delay. np > On Mon, Apr 20, 2015 at 05:43:07PM +0200, Petr Mladek wrote: > > I was afraid that there might be a potential buffer overflow because > > the user-provided dict need not be limited by '\0'. But LOG_DICT_M

Re: [PATCH 04/16] printk: implement support for extended console drivers

2015-04-27 Thread Tejun Heo
Hello, Petr. Sorry about the delay. On Mon, Apr 20, 2015 at 05:43:07PM +0200, Petr Mladek wrote: ... > > * Extended message formatting for console drivers is enabled iff there > > s/iff/if/ if and only if > I was afraid that there might be a potential buffer overflow because > the user-provide

Re: [PATCH 04/16] printk: implement support for extended console drivers

2015-04-21 Thread Petr Mladek
On Mon 2015-04-20 17:43:07, Petr Mladek wrote: > On Thu 2015-04-16 19:03:41, Tejun Heo wrote: > > printk log_buf keeps various metadata for each message including its > > sequence number and timestamp. The metadata is currently available > > only through /dev/kmsg and stripped out before passed on

Re: [PATCH 04/16] printk: implement support for extended console drivers

2015-04-20 Thread Petr Mladek
On Thu 2015-04-16 19:03:41, Tejun Heo wrote: > printk log_buf keeps various metadata for each message including its > sequence number and timestamp. The metadata is currently available > only through /dev/kmsg and stripped out before passed onto console > drivers. We want this metadata to be avai

[PATCH 04/16] printk: implement support for extended console drivers

2015-04-16 Thread Tejun Heo
printk log_buf keeps various metadata for each message including its sequence number and timestamp. The metadata is currently available only through /dev/kmsg and stripped out before passed onto console drivers. We want this metadata to be available to console drivers too. Immediately, it's to i