Re: [PATCH 04/17] auxdisplay: img-ascii-lcd: Add helper variable dev

2021-03-22 Thread Geert Uytterhoeven
Hi Miguel, On Mon, Mar 22, 2021 at 5:59 PM Miguel Ojeda wrote: > On Mon, Mar 22, 2021 at 3:48 PM Geert Uytterhoeven > wrote: > > + struct device *dev = &pdev->dev; > > Do we want helpers like this to be `*const` (assuming they can)? (same > for patch 12). No, e.g. the devm_*() functions

Re: [PATCH 04/17] auxdisplay: img-ascii-lcd: Add helper variable dev

2021-03-22 Thread Miguel Ojeda
On Mon, Mar 22, 2021 at 3:48 PM Geert Uytterhoeven wrote: > > + struct device *dev = &pdev->dev; Do we want helpers like this to be `*const` (assuming they can)? (same for patch 12). Cheers, Miguel

[PATCH 04/17] auxdisplay: img-ascii-lcd: Add helper variable dev

2021-03-22 Thread Geert Uytterhoeven
img_ascii_lcd_probe() has many users of "pdev->dev". Add a shorthand to simplify the code. Signed-off-by: Geert Uytterhoeven --- drivers/auxdisplay/img-ascii-lcd.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/aux