Re: [PATCH 04/32] aio: remove retry-based AIO

2013-01-07 Thread Kent Overstreet
On Sat, Dec 29, 2012 at 03:47:37PM +0800, Hillf Danton wrote: > On Thu, Dec 27, 2012 at 9:59 AM, Kent Overstreet > wrote: > > @@ -1585,18 +1278,27 @@ static int io_submit_one(struct kioctx *ctx, struct > > iocb __user *user_iocb, > > * don't see ctx->dead set here, io_destroy() waits fo

Re: [PATCH 04/32] aio: remove retry-based AIO

2013-01-07 Thread Kent Overstreet
On Sat, Dec 29, 2012 at 03:36:38PM +0800, Hillf Danton wrote: > On Thu, Dec 27, 2012 at 9:59 AM, Kent Overstreet > wrote: > > - /* > > -* This is so that aio_complete knows it doesn't need to > > -* pull the iocb off the run list (We can't just call > > -* INIT_LIST_

Re: [PATCH 04/32] aio: remove retry-based AIO

2012-12-28 Thread Hillf Danton
On Thu, Dec 27, 2012 at 9:59 AM, Kent Overstreet wrote: > @@ -1585,18 +1278,27 @@ static int io_submit_one(struct kioctx *ctx, struct > iocb __user *user_iocb, > * don't see ctx->dead set here, io_destroy() waits for our IO to > * finish. > */ > - if (ctx->dead) {

Re: [PATCH 04/32] aio: remove retry-based AIO

2012-12-28 Thread Hillf Danton
On Thu, Dec 27, 2012 at 9:59 AM, Kent Overstreet wrote: > - /* > -* This is so that aio_complete knows it doesn't need to > -* pull the iocb off the run list (We can't just call > -* INIT_LIST_HEAD because we don't want a kick_iocb to > -* queue this on the ru

[PATCH 04/32] aio: remove retry-based AIO

2012-12-26 Thread Kent Overstreet
From: Zach Brown This removes the retry-based AIO infrastructure now that nothing in tree is using it. We want to remove retry-based AIO because it is fundemantally unsafe. It retries IO submission from a kernel thread that has only assumed the mm of the submitting task. All other task_struct r