Re: [PATCH 04/39] vfs: add path_open()

On Mon, Jun 04, 2018 at 01:46:09AM -0700, Christoph Hellwig wrote: > > +EXPORT_SYMBOL(path_open); > > EXPORT_SYMBOL_GPL, please. No. If interface makes sense, export it. If it doens't, don't. Don't mix "it's a shit API, but we need it for some in-kernel module" with "out-of-tree

Re: [PATCH 04/39] vfs: add path_open()

> +EXPORT_SYMBOL(path_open); EXPORT_SYMBOL_GPL, please.

[PATCH 04/39] vfs: add path_open()

Currently opening an overlay file results in: - the real file on the underlying layer being opened - f_path being set to the overlay {mount, dentry} pair This patch adds a new helper that allows the above to be explicitly performed. I.e. it's the same as dentry_open(), except the underlying in