Re: [PATCH 05/10] iommu/amd: remove the special case from get_irq_table()

2018-03-15 Thread Sebastian Andrzej Siewior
On 2018-03-15 16:19:17 [+0100], Joerg Roedel wrote: > Okay, if the irq-layer does the needed locking, then we don't need > another lock here. There is the modify_irte_ga() path for the > virtualized irq routing into KVM guests, but there should be no KVM > guests running when setup the ioapic routi

Re: [PATCH 05/10] iommu/amd: remove the special case from get_irq_table()

2018-03-15 Thread Joerg Roedel
On Thu, Mar 15, 2018 at 03:15:41PM +0100, Sebastian Andrzej Siewior wrote: > ->set_allocated() operates only on 0…31 and other could be used at the > same time. However 0…31 should be accessed by other user before they are > ready. > > irq_remapping_alloc() is that ->alloc() callback invoked via >

Re: [PATCH 05/10] iommu/amd: remove the special case from get_irq_table()

2018-03-15 Thread Sebastian Andrzej Siewior
On 2018-03-15 14:07:23 [+0100], Joerg Roedel wrote: > On Thu, Mar 15, 2018 at 02:01:53PM +0100, Sebastian Andrzej Siewior wrote: > > On 2018-03-15 13:53:42 [+0100], Joerg Roedel wrote: > > > On Fri, Feb 23, 2018 at 11:27:31PM +0100, Sebastian Andrzej Siewior wrote: > > > > @@ -4103,10 +4093,26 @@ s

Re: [PATCH 05/10] iommu/amd: remove the special case from get_irq_table()

2018-03-15 Thread Joerg Roedel
On Thu, Mar 15, 2018 at 02:01:53PM +0100, Sebastian Andrzej Siewior wrote: > On 2018-03-15 13:53:42 [+0100], Joerg Roedel wrote: > > On Fri, Feb 23, 2018 at 11:27:31PM +0100, Sebastian Andrzej Siewior wrote: > > > @@ -4103,10 +4093,26 @@ static int irq_remapping_alloc(struct irq_domain > > > *doma

Re: [PATCH 05/10] iommu/amd: remove the special case from get_irq_table()

2018-03-15 Thread Sebastian Andrzej Siewior
On 2018-03-15 13:53:42 [+0100], Joerg Roedel wrote: > On Fri, Feb 23, 2018 at 11:27:31PM +0100, Sebastian Andrzej Siewior wrote: > > @@ -4103,10 +4093,26 @@ static int irq_remapping_alloc(struct irq_domain > > *domain, unsigned int virq, > > return ret; > > > > if (info->type ==

Re: [PATCH 05/10] iommu/amd: remove the special case from get_irq_table()

2018-03-15 Thread Joerg Roedel
On Fri, Feb 23, 2018 at 11:27:31PM +0100, Sebastian Andrzej Siewior wrote: > @@ -4103,10 +4093,26 @@ static int irq_remapping_alloc(struct irq_domain > *domain, unsigned int virq, > return ret; > > if (info->type == X86_IRQ_ALLOC_TYPE_IOAPIC) { > - if (get_irq_tab

[PATCH 05/10] iommu/amd: remove the special case from get_irq_table()

2018-02-23 Thread Sebastian Andrzej Siewior
get_irq_table() has a special ioapic argument. If set then it will pre-allocate / reserve the first 32 indexes. The argument is only once true and it would make get_irq_table() a little simpler if we would extract the special bits to the caller. Signed-off-by: Sebastian Andrzej Siewior --- drive