Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation

2016-06-08 Thread Johannes Weiner
On Wed, Jun 08, 2016 at 04:39:44PM +0900, Minchan Kim wrote: > On Mon, Jun 06, 2016 at 03:48:31PM -0400, Johannes Weiner wrote: > > @@ -832,9 +854,9 @@ static void __pagevec_lru_add_fn(struct page *page, > > struct lruvec *lruvec, > > * Add the passed pages to the LRU, then drop the caller's ref

Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation

2016-06-08 Thread Minchan Kim
On Mon, Jun 06, 2016 at 03:48:31PM -0400, Johannes Weiner wrote: > Isolating an existing LRU page and subsequently putting it back on the > list currently influences the balance between the anon and file LRUs. > For example, heavy page migration or compaction could influence the > balance between t

Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation

2016-06-07 Thread Johannes Weiner
On Tue, Jun 07, 2016 at 11:26:29AM +0200, Michal Hocko wrote: > On Mon 06-06-16 18:15:50, Johannes Weiner wrote: > [...] > > The last hunk in the patch (obscured by showing the label instead of > > the function name as context) > > JFYI my ~/.gitconfig has the following to workaround this: > [diff

Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation

2016-06-07 Thread Johannes Weiner
On Mon, Jun 06, 2016 at 09:11:18PM -0400, Rik van Riel wrote: > On Mon, 2016-06-06 at 18:15 -0400, Johannes Weiner wrote: > > On Mon, Jun 06, 2016 at 05:56:09PM -0400, Rik van Riel wrote: > > > > > > On Mon, 2016-06-06 at 15:48 -0400, Johannes Weiner wrote: > > > > > > > >   > > > > +void lru_cac

Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation

2016-06-07 Thread Michal Hocko
On Mon 06-06-16 15:48:31, Johannes Weiner wrote: > Isolating an existing LRU page and subsequently putting it back on the > list currently influences the balance between the anon and file LRUs. > For example, heavy page migration or compaction could influence the > balance between the LRUs and make

Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation

2016-06-07 Thread Michal Hocko
On Mon 06-06-16 18:15:50, Johannes Weiner wrote: [...] > The last hunk in the patch (obscured by showing the label instead of > the function name as context) JFYI my ~/.gitconfig has the following to workaround this: [diff "default"] xfuncname = "^[[:alpha:]$_].*[^:]$" -- Michal Hocko SU

Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation

2016-06-06 Thread Rik van Riel
On Mon, 2016-06-06 at 18:15 -0400, Johannes Weiner wrote: > On Mon, Jun 06, 2016 at 05:56:09PM -0400, Rik van Riel wrote: > > > > On Mon, 2016-06-06 at 15:48 -0400, Johannes Weiner wrote: > > > > > >   > > > +void lru_cache_putback(struct page *page) > > > +{ > > > + struct pagevec *pvec = &get_c

Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation

2016-06-06 Thread Johannes Weiner
On Mon, Jun 06, 2016 at 05:56:09PM -0400, Rik van Riel wrote: > On Mon, 2016-06-06 at 15:48 -0400, Johannes Weiner wrote: > >  > > +void lru_cache_putback(struct page *page) > > +{ > > + struct pagevec *pvec = &get_cpu_var(lru_putback_pvec); > > + > > + get_page(page); > > + if (!pagevec_spac

Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation

2016-06-06 Thread Rik van Riel
On Mon, 2016-06-06 at 15:48 -0400, Johannes Weiner wrote: >  > +void lru_cache_putback(struct page *page) > +{ > + struct pagevec *pvec = &get_cpu_var(lru_putback_pvec); > + > + get_page(page); > + if (!pagevec_space(pvec)) > + __pagevec_lru_add(pvec, false); > + pagevec

[PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation

2016-06-06 Thread Johannes Weiner
Isolating an existing LRU page and subsequently putting it back on the list currently influences the balance between the anon and file LRUs. For example, heavy page migration or compaction could influence the balance between the LRUs and make one type more attractive when that type of page is affec