Re: [PATCH 05/10 V2] workqueue: separate iteration role from worker_idr

2014-05-12 Thread Tejun Heo
Oops, one more thing. On Mon, May 12, 2014 at 02:56:17PM +0800, Lai Jiangshan wrote: > - struct idr worker_idr; /* M: worker IDs and iteration > */ > + struct idr worker_idr; /* M: worker IDs */ > + struct list_headworkers;/* M: attach

Re: [PATCH 05/10 V2] workqueue: separate iteration role from worker_idr

2014-05-12 Thread Tejun Heo
On Mon, May 12, 2014 at 02:56:17PM +0800, Lai Jiangshan wrote: > worker_idr has the iteration(iterating for attached workers) and worker ID ^ Please put a space before an opening parenthses. It becomes a lot easier on the eyes. > duties. These two duties are not nece

[PATCH 05/10 V2] workqueue: separate iteration role from worker_idr

2014-05-11 Thread Lai Jiangshan
worker_idr has the iteration(iterating for attached workers) and worker ID duties. These two duties are not necessary tied together. We can separate them and use a list for tracking attached workers and iteration After separation, we can add the rescuer workers to the list for iteration in future.