Re: [PATCH 05/11] HID: HIDp: remove hidp_hidinput_event

2014-02-03 Thread Benjamin Tissoires
On Mon, Feb 3, 2014 at 10:10 AM, David Herrmann wrote: > Hi > > On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires > wrote: >> hidp uses its own ->hidinput_input_event() instead of the generic binding >> in hid-input. >> Moving the handling of LEDs towards hidp_hidinput_event() allows two

Re: [PATCH 05/11] HID: HIDp: remove hidp_hidinput_event

2014-02-03 Thread David Herrmann
Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires wrote: > hidp uses its own ->hidinput_input_event() instead of the generic binding > in hid-input. > Moving the handling of LEDs towards hidp_hidinput_event() allows two things: > - remove hidinput_input_event definitively from struct

Re: [PATCH 05/11] HID: HIDp: remove hidp_hidinput_event

2014-02-03 Thread David Herrmann
Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: hidp uses its own -hidinput_input_event() instead of the generic binding in hid-input. Moving the handling of LEDs towards hidp_hidinput_event() allows two things: - remove hidinput_input_event

Re: [PATCH 05/11] HID: HIDp: remove hidp_hidinput_event

2014-02-03 Thread Benjamin Tissoires
On Mon, Feb 3, 2014 at 10:10 AM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: hidp uses its own -hidinput_input_event() instead of the generic binding in hid-input. Moving the handling of LEDs towards

[PATCH 05/11] HID: HIDp: remove hidp_hidinput_event

2014-02-01 Thread Benjamin Tissoires
hidp uses its own ->hidinput_input_event() instead of the generic binding in hid-input. Moving the handling of LEDs towards hidp_hidinput_event() allows two things: - remove hidinput_input_event definitively from struct hid_device - hidraw user space programs can also set the LEDs Signed-off-by:

[PATCH 05/11] HID: HIDp: remove hidp_hidinput_event

2014-02-01 Thread Benjamin Tissoires
hidp uses its own -hidinput_input_event() instead of the generic binding in hid-input. Moving the handling of LEDs towards hidp_hidinput_event() allows two things: - remove hidinput_input_event definitively from struct hid_device - hidraw user space programs can also set the LEDs Signed-off-by: