Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-08 Thread Bartosz Golaszewski
pt., 8 maj 2020 o 07:54 Heiner Kallweit napisał(a): > > On 08.05.2020 00:56, Jakub Kicinski wrote: > > On Thu, 7 May 2020 19:03:44 +0200 Bartosz Golaszewski wrote: > >>> To implement Edwin's suggestion? Makes sense, but I'm no expert, let's > >>> also CC Heiner since he was asking about it last ti

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-07 Thread Heiner Kallweit
On 08.05.2020 00:56, Jakub Kicinski wrote: > On Thu, 7 May 2020 19:03:44 +0200 Bartosz Golaszewski wrote: >>> To implement Edwin's suggestion? Makes sense, but I'm no expert, let's >>> also CC Heiner since he was asking about it last time. >> >> Yes, because taking the last bit of priv_flags from

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-07 Thread Jakub Kicinski
On Thu, 7 May 2020 19:03:44 +0200 Bartosz Golaszewski wrote: >> To implement Edwin's suggestion? Makes sense, but I'm no expert, let's >> also CC Heiner since he was asking about it last time. > > Yes, because taking the last bit of priv_flags from net_device seems > to be more controversial but

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-07 Thread Bartosz Golaszewski
czw., 7 maj 2020 o 18:53 Jakub Kicinski napisał(a): > > On Thu, 7 May 2020 11:25:01 +0200 Bartosz Golaszewski wrote: > > śr., 6 maj 2020 o 19:12 Jakub Kicinski napisał(a): > > > > > > On Wed, 6 May 2020 08:39:47 +0200 Bartosz Golaszewski wrote: > > > > wt., 5 maj 2020 o 19:31 Jakub Kicinski napi

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-07 Thread Jakub Kicinski
On Thu, 7 May 2020 11:25:01 +0200 Bartosz Golaszewski wrote: > śr., 6 maj 2020 o 19:12 Jakub Kicinski napisał(a): > > > > On Wed, 6 May 2020 08:39:47 +0200 Bartosz Golaszewski wrote: > > > wt., 5 maj 2020 o 19:31 Jakub Kicinski napisał(a): > > > > > > > > On Tue, 5 May 2020 16:02:25 +0200 Ba

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-07 Thread Bartosz Golaszewski
śr., 6 maj 2020 o 19:12 Jakub Kicinski napisał(a): > > On Wed, 6 May 2020 08:39:47 +0200 Bartosz Golaszewski wrote: > > wt., 5 maj 2020 o 19:31 Jakub Kicinski napisał(a): > > > > > > On Tue, 5 May 2020 16:02:25 +0200 Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > > > > > P

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-06 Thread Edwin Peer
On Tue, May 5, 2020 at 11:46 PM Bartosz Golaszewski wrote: > Re the last bit in priv_flags: is this really a problem though? It's > not like struct net_device must remain stable - e.g. we can make > priv_flags a bitmap. Fair enough. Regards, Edwin Peer

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-06 Thread Jakub Kicinski
On Wed, 6 May 2020 08:39:47 +0200 Bartosz Golaszewski wrote: > wt., 5 maj 2020 o 19:31 Jakub Kicinski napisał(a): > > > > On Tue, 5 May 2020 16:02:25 +0200 Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > Provide devm_register_netdev() - a device resource managed variant

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-05 Thread Bartosz Golaszewski
wt., 5 maj 2020 o 21:25 Edwin Peer napisał(a): > > + > > +static void devm_netdev_release(struct device *dev, void *this) > > +{ > > + struct netdevice_devres *res = this; > > + > > + unregister_netdev(res->ndev); > > +} > > + > > +/** > > + * devm_register_netdev - resource manage

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-05 Thread Bartosz Golaszewski
wt., 5 maj 2020 o 19:31 Jakub Kicinski napisał(a): > > On Tue, 5 May 2020 16:02:25 +0200 Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Provide devm_register_netdev() - a device resource managed variant > > of register_netdev(). This new helper will only work for net_device > >

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-05 Thread Edwin Peer
On Tue, May 5, 2020 at 7:05 AM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > Provide devm_register_netdev() - a device resource managed variant > of register_netdev(). This new helper will only work for net_device > structs that have a parent device assigned and are devres managed

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-05 Thread Jakub Kicinski
On Tue, 5 May 2020 16:02:25 +0200 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Provide devm_register_netdev() - a device resource managed variant > of register_netdev(). This new helper will only work for net_device > structs that have a parent device assigned and are devres manage

[PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Provide devm_register_netdev() - a device resource managed variant of register_netdev(). This new helper will only work for net_device structs that have a parent device assigned and are devres managed too. Signed-off-by: Bartosz Golaszewski --- include/linux/netdevice