Re: [PATCH 05/11] of: Ratify of_dma_configure() interface

2019-10-07 Thread Nicolas Saenz Julienne
On Thu, 2019-10-03 at 20:53 -0500, Rob Herring wrote: > > > > But I think that with this series, given the fact that we now treat the > > > > lack > > > > of > > > > dma-ranges as a 1:1 mapping instead of an error, we could rewrite the > > > > function > > > > like this: > > > > > > Now, I'm recon

Re: [PATCH 05/11] of: Ratify of_dma_configure() interface

2019-10-03 Thread Rob Herring
On Tue, Oct 1, 2019 at 10:43 AM Nicolas Saenz Julienne wrote: > > On Mon, 2019-09-30 at 16:24 -0500, Rob Herring wrote: > > On Mon, Sep 30, 2019 at 8:32 AM Nicolas Saenz Julienne > > wrote: > > > On Mon, 2019-09-30 at 05:57 -0700, Christoph Hellwig wrote: > > > > On Thu, Sep 26, 2019 at 07:24:49P

Re: [PATCH 05/11] of: Ratify of_dma_configure() interface

2019-10-01 Thread Nicolas Saenz Julienne
On Mon, 2019-09-30 at 16:24 -0500, Rob Herring wrote: > On Mon, Sep 30, 2019 at 8:32 AM Nicolas Saenz Julienne > wrote: > > On Mon, 2019-09-30 at 05:57 -0700, Christoph Hellwig wrote: > > > On Thu, Sep 26, 2019 at 07:24:49PM -0500, Rob Herring wrote: > > > > -int of_dma_configure(struct device *de

Re: [PATCH 05/11] of: Ratify of_dma_configure() interface

2019-09-30 Thread Rob Herring
On Mon, Sep 30, 2019 at 8:32 AM Nicolas Saenz Julienne wrote: > > On Mon, 2019-09-30 at 05:57 -0700, Christoph Hellwig wrote: > > On Thu, Sep 26, 2019 at 07:24:49PM -0500, Rob Herring wrote: > > > -int of_dma_configure(struct device *dev, struct device_node *np, bool > > > force_dma) > > > +int of

Re: [PATCH 05/11] of: Ratify of_dma_configure() interface

2019-09-30 Thread Nicolas Saenz Julienne
On Mon, 2019-09-30 at 05:57 -0700, Christoph Hellwig wrote: > On Thu, Sep 26, 2019 at 07:24:49PM -0500, Rob Herring wrote: > > -int of_dma_configure(struct device *dev, struct device_node *np, bool > > force_dma) > > +int of_dma_configure(struct device *dev, struct device_node *parent, bool > > for

Re: [PATCH 05/11] of: Ratify of_dma_configure() interface

2019-09-30 Thread Christoph Hellwig
On Thu, Sep 26, 2019 at 07:24:49PM -0500, Rob Herring wrote: > -int of_dma_configure(struct device *dev, struct device_node *np, bool > force_dma) > +int of_dma_configure(struct device *dev, struct device_node *parent, bool > force_dma) This creates a > 80 char line. > { > u64 dma_addr,

[PATCH 05/11] of: Ratify of_dma_configure() interface

2019-09-26 Thread Rob Herring
From: Robin Murphy For various DMA masters not directly represented in DT, we pass the OF node of their parent or bridge device as the master_np argument to of_dma_configure(), such that they can inherit the appropriate DMA configuration from whatever is described there. This creates an ambiguity