Re: [PATCH 05/11] trace-cmd: Rename trace_profile() to trace_profile_int()

2017-11-28 Thread Vladislav Valtchev
On Tue, 2017-11-28 at 12:05 -0500, Steven Rostedt wrote: > > Couple of things. > > 1) A change like this should always be directly before the patch that > requires it. This is patch 5, and it's not until patch 8 that this > change is required. Please keep them next to each other. This should > ha

Re: [PATCH 05/11] trace-cmd: Rename trace_profile() to trace_profile_int()

2017-11-28 Thread Steven Rostedt
On Thu, 23 Nov 2017 18:33:29 +0200 "Vladislav Valtchev (VMware)" wrote: > The purpose of this renaming is to make room for a new trace_profile() > function, > that will handle directly the 'profile' command, following the internal > convention COMMAND_NAME -> trace_{COMMAND_NAME}. Couple of thi

[PATCH 05/11] trace-cmd: Rename trace_profile() to trace_profile_int()

2017-11-23 Thread Vladislav Valtchev (VMware)
The purpose of this renaming is to make room for a new trace_profile() function, that will handle directly the 'profile' command, following the internal convention COMMAND_NAME -> trace_{COMMAND_NAME}. Clearly, in the next steps the top-level trace_profile() function will be made to call trace_pro