Re: [PATCH 05/11] x86 topology: export die_siblings

2019-02-21 Thread Brice Goglin
Le 21/02/2019 à 08:41, Len Brown a écrit : > > Here is my list of applications that care about the new CPUID leaf > and the concepts of packages and die: > > cpuid > lscpu > x86_energy_perf_policy > turbostat You may add hwloc/lstopo which is used by most HPC runtimes (including your employers'

Re: [PATCH 05/11] x86 topology: export die_siblings

2019-02-20 Thread Len Brown
Hi Brice, Thank you for your suggestions! > Patches #4 and #5 are changing the meaning the core_siblings (in the > past, it always returned all threads in the entire package). All > existing user-space tools will see each die as a separate package until > they are updated to read die_siblings too.

Re: [PATCH 05/11] x86 topology: export die_siblings

2019-02-20 Thread Brice Goglin
Le 19/02/2019 à 04:40, Len Brown a écrit : > From: Len Brown > > like core_siblings, except it shows which die are in the same package. > > This is needed for lscpu(1) to correctly display die topology. > > Signed-off-by: Len Brown > Cc: linux-...@vger.kernel.org > Signed-off-by: Len Brown > ---

Re: [PATCH 05/11] x86 topology: export die_siblings

2019-02-20 Thread Peter Zijlstra
On Tue, Feb 19, 2019 at 02:33:59PM -0500, Liang, Kan wrote: > Besides the generic document, I think we should update x86 document as well, > which is in Documentation/x86/topology.txt. > > The definition of topology_core_cpumask has to be changed to per die, right? That's what the change to match

Re: [PATCH 05/11] x86 topology: export die_siblings

2019-02-19 Thread Liang, Kan
On 2/19/2019 1:43 PM, Brown, Len wrote: Thanks for the comments, Kan, diff --git a/Documentation/cputopology.txt b/Documentation/cputopology.txt index 287213b4517b..7dd2ae3df233 100644 --- a/Documentation/cputopology.txt +++ b/Documentation/cputopology.txt @@ -56,6 +56,16 @@ core_siblings_li

RE: [PATCH 05/11] x86 topology: export die_siblings

2019-02-19 Thread Brown, Len
Thanks for the comments, Kan, >> diff --git a/Documentation/cputopology.txt >> b/Documentation/cputopology.txt index 287213b4517b..7dd2ae3df233 >> 100644 >> --- a/Documentation/cputopology.txt >> +++ b/Documentation/cputopology.txt >> @@ -56,6 +56,16 @@ core_siblings_list: >> human-readable

Re: [PATCH 05/11] x86 topology: export die_siblings

2019-02-19 Thread Liang, Kan
On 2/18/2019 10:40 PM, Len Brown wrote: From: Len Brown like core_siblings, except it shows which die are in the same package. This is needed for lscpu(1) to correctly display die topology. Signed-off-by: Len Brown Cc: linux-...@vger.kernel.org Signed-off-by: Len Brown --- Documentatio

[PATCH 05/11] x86 topology: export die_siblings

2019-02-18 Thread Len Brown
From: Len Brown like core_siblings, except it shows which die are in the same package. This is needed for lscpu(1) to correctly display die topology. Signed-off-by: Len Brown Cc: linux-...@vger.kernel.org Signed-off-by: Len Brown --- Documentation/cputopology.txt | 10 ++ arch/x86/