Re: [PATCH 05/12] scsi/NCR5380: fix build failures when debugging is enabled

2014-05-28 Thread Christoph Hellwig
On Wed, May 28, 2014 at 10:09:33PM +1000, Finn Thain wrote: > [PATCH v2 05/12] scsi/NCR5380: fix build failures when debugging is enabled > [PATCH v2 06/12] scsi/NCR5380: fix dprintk macro usage and definition > [PATCH v2 09/12] scsi/NCR5380: fix and standardize NDEBUG macros > &

Re: [PATCH 05/12] scsi/NCR5380: fix build failures when debugging is enabled

2014-05-28 Thread Finn Thain
On Wed, 28 May 2014, Christoph Hellwig wrote: > Looks good, > > Reviewed-by: Christoph Hellwig > Thanks for reviewing. There was a later submission (version 2) with changes made to three of these patches, [PATCH v2 05/12] scsi/NCR5380: fix build failures when debugging is enabl

Re: [PATCH 05/12] scsi/NCR5380: fix build failures when debugging is enabled

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:17AM +1100, Finn Thain wrote: > The change from cmd->target to cmd->device->id was apparently the purpose of > commit a7f251228390e87d86c5e3846f99a455517fdd8e in > kernel/git/tglx/history.git but some instances have been missed. > > Also fix the

Re: [PATCH 05/12] scsi/NCR5380: fix build failures when debugging is enabled

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:17AM +1100, Finn Thain wrote: The change from cmd-target to cmd-device-id was apparently the purpose of commit a7f251228390e87d86c5e3846f99a455517fdd8e in kernel/git/tglx/history.git but some instances have been missed. Also fix the NDEBUG_LAST_WRITE_SENT and

Re: [PATCH 05/12] scsi/NCR5380: fix build failures when debugging is enabled

2014-05-28 Thread Finn Thain
On Wed, 28 May 2014, Christoph Hellwig wrote: Looks good, Reviewed-by: Christoph Hellwig h...@lst.de Thanks for reviewing. There was a later submission (version 2) with changes made to three of these patches, [PATCH v2 05/12] scsi/NCR5380: fix build failures when debugging is enabled

Re: [PATCH 05/12] scsi/NCR5380: fix build failures when debugging is enabled

2014-05-28 Thread Christoph Hellwig
On Wed, May 28, 2014 at 10:09:33PM +1000, Finn Thain wrote: [PATCH v2 05/12] scsi/NCR5380: fix build failures when debugging is enabled [PATCH v2 06/12] scsi/NCR5380: fix dprintk macro usage and definition [PATCH v2 09/12] scsi/NCR5380: fix and standardize NDEBUG macros And several patches

[PATCH 05/12] scsi/NCR5380: fix build failures when debugging is enabled

2014-03-17 Thread Finn Thain
The change from cmd->target to cmd->device->id was apparently the purpose of commit a7f251228390e87d86c5e3846f99a455517fdd8e in kernel/git/tglx/history.git but some instances have been missed. Also fix the "NDEBUG_LAST_WRITE_SENT" and "NDEBUG_ALL" typo's. Also fix some format strings (%ul

[PATCH 05/12] scsi/NCR5380: fix build failures when debugging is enabled

2014-03-17 Thread Finn Thain
The change from cmd-target to cmd-device-id was apparently the purpose of commit a7f251228390e87d86c5e3846f99a455517fdd8e in kernel/git/tglx/history.git but some instances have been missed. Also fix the NDEBUG_LAST_WRITE_SENT and NDEBUG_ALL typo's. Also fix some format strings (%ul becomes %lu)