Re: [PATCH 05/13] vfs: don't parse "silent" option

2019-06-24 Thread Miklos Szeredi
On Mon, Jun 24, 2019 at 12:44 PM Miklos Szeredi wrote: > > On Mon, Jun 24, 2019 at 12:36 PM David Howells wrote: > > > > Miklos Szeredi wrote: > > > > > What I'm saying is that with a new interface the rules need not follow > > > the rules of the old interface, because at the start no one is

Re: [PATCH 05/13] vfs: don't parse "silent" option

2019-06-24 Thread Miklos Szeredi
On Mon, Jun 24, 2019 at 12:36 PM David Howells wrote: > > Miklos Szeredi wrote: > > > What I'm saying is that with a new interface the rules need not follow > > the rules of the old interface, because at the start no one is using > > the new interface, so no chance of breaking anything. > > Er.

Re: [PATCH 05/13] vfs: don't parse "silent" option

2019-06-24 Thread David Howells
Miklos Szeredi wrote: > What I'm saying is that with a new interface the rules need not follow > the rules of the old interface, because at the start no one is using > the new interface, so no chance of breaking anything. Er. No. That's not true, since the old interface comes through the new

Re: [PATCH 05/13] vfs: don't parse "silent" option

2019-06-24 Thread Miklos Szeredi
On Thu, Jun 20, 2019 at 6:40 AM Ian Kent wrote: > > On Wed, 2019-06-19 at 14:30 +0200, Miklos Szeredi wrote: > > While this is a standard option as documented in mount(8), it is ignored by > > most filesystems. So reject, unless filesystem explicitly wants to handle > > it. > > > > The exception

Re: [PATCH 05/13] vfs: don't parse "silent" option

2019-06-19 Thread Ian Kent
On Wed, 2019-06-19 at 14:30 +0200, Miklos Szeredi wrote: > While this is a standard option as documented in mount(8), it is ignored by > most filesystems. So reject, unless filesystem explicitly wants to handle > it. > > The exception is unconverted filesystems, where it is unknown if the >

[PATCH 05/13] vfs: don't parse "silent" option

2019-06-19 Thread Miklos Szeredi
While this is a standard option as documented in mount(8), it is ignored by most filesystems. So reject, unless filesystem explicitly wants to handle it. The exception is unconverted filesystems, where it is unknown if the filesystem handles this or not. Any implementation, such as mount(8)