Re: [PATCH 05/15] habanalabs: add command buffer module

2019-01-28 Thread Mike Rapoport
On Mon, Jan 28, 2019 at 09:55:23AM +0200, Oded Gabbay wrote: > On Sun, Jan 27, 2019 at 8:49 AM Mike Rapoport wrote: > > > > On Fri, Jan 25, 2019 at 11:47:03PM +0200, Oded Gabbay wrote: > > > On Wed, Jan 23, 2019 at 2:28 PM Mike Rapoport wrote: > > > > > > > > On Wed, Jan 23, 2019 at 02:00:47AM +0

Re: [PATCH 05/15] habanalabs: add command buffer module

2019-01-27 Thread Oded Gabbay
On Sun, Jan 27, 2019 at 8:49 AM Mike Rapoport wrote: > > On Fri, Jan 25, 2019 at 11:47:03PM +0200, Oded Gabbay wrote: > > On Wed, Jan 23, 2019 at 2:28 PM Mike Rapoport wrote: > > > > > > On Wed, Jan 23, 2019 at 02:00:47AM +0200, Oded Gabbay wrote: > > > > This patch adds the CB module, which allo

Re: [PATCH 05/15] habanalabs: add command buffer module

2019-01-26 Thread Mike Rapoport
On Fri, Jan 25, 2019 at 11:47:03PM +0200, Oded Gabbay wrote: > On Wed, Jan 23, 2019 at 2:28 PM Mike Rapoport wrote: > > > > On Wed, Jan 23, 2019 at 02:00:47AM +0200, Oded Gabbay wrote: > > > This patch adds the CB module, which allows the user to create and > > > destroy CBs and to map them to the

Re: [PATCH 05/15] habanalabs: add command buffer module

2019-01-25 Thread Oded Gabbay
On Wed, Jan 23, 2019 at 2:28 PM Mike Rapoport wrote: > > On Wed, Jan 23, 2019 at 02:00:47AM +0200, Oded Gabbay wrote: > > This patch adds the CB module, which allows the user to create and > > destroy CBs and to map them to the user's process address-space. > > Can you please spell "command buffer

Re: [PATCH 05/15] habanalabs: add command buffer module

2019-01-23 Thread Mike Rapoport
On Wed, Jan 23, 2019 at 02:00:47AM +0200, Oded Gabbay wrote: > This patch adds the CB module, which allows the user to create and > destroy CBs and to map them to the user's process address-space. Can you please spell "command buffer" at least first time it's mentioned? > A command buffer is a m

[PATCH 05/15] habanalabs: add command buffer module

2019-01-22 Thread Oded Gabbay
This patch adds the CB module, which allows the user to create and destroy CBs and to map them to the user's process address-space. A command buffer is a memory blocks that reside in DMA-able address-space and is physically contiguous so it can be accessed by the device without MMU translation. Th