Re: [PATCH 05/19] irqchip/mmp: do not use of_address_to_resource() to get mux regs

2019-08-17 Thread Marc Zyngier
On Fri, 16 Aug 2019 20:41:22 +0200 Lubomir Rintel wrote: > On Fri, 2019-08-09 at 13:12 +0100, Marc Zyngier wrote: > > On 09/08/2019 10:31, Lubomir Rintel wrote: > > > The "regs" property of the "mrvl,mmp2-mux-intc" devices are silly. They > > > are offsets from intc's base, not addresses on the

Re: [PATCH 05/19] irqchip/mmp: do not use of_address_to_resource() to get mux regs

2019-08-16 Thread Lubomir Rintel
On Fri, 2019-08-09 at 13:12 +0100, Marc Zyngier wrote: > On 09/08/2019 10:31, Lubomir Rintel wrote: > > The "regs" property of the "mrvl,mmp2-mux-intc" devices are silly. They > > are offsets from intc's base, not addresses on the parent bus. At this > > point it probably can't be fixed. > > > > O

Re: [PATCH 05/19] irqchip/mmp: do not use of_address_to_resource() to get mux regs

2019-08-09 Thread Marc Zyngier
On 09/08/2019 10:31, Lubomir Rintel wrote: > The "regs" property of the "mrvl,mmp2-mux-intc" devices are silly. They > are offsets from intc's base, not addresses on the parent bus. At this > point it probably can't be fixed. > > On an OLPC XO-1.75 machine, the muxes are children of the intc, not

[PATCH 05/19] irqchip/mmp: do not use of_address_to_resource() to get mux regs

2019-08-09 Thread Lubomir Rintel
The "regs" property of the "mrvl,mmp2-mux-intc" devices are silly. They are offsets from intc's base, not addresses on the parent bus. At this point it probably can't be fixed. On an OLPC XO-1.75 machine, the muxes are children of the intc, not the axi bus, and thus of_address_to_resource() won't