Re: [PATCH 05/19] mmc: mmci: allow to overwrite clock/power procedure to specific variant

2018-07-11 Thread Ulf Hansson
[...] >> 2) The clock register will be written to before the regulator >> operations have been done. Not sure if that works fine!? > > > you are right, it's probably better if the clock is done after power. > do you agree if I change the order? If the new ST variant can cope with the existing

Re: [PATCH 05/19] mmc: mmci: allow to overwrite clock/power procedure to specific variant

2018-07-11 Thread Ulf Hansson
[...] >> 2) The clock register will be written to before the regulator >> operations have been done. Not sure if that works fine!? > > > you are right, it's probably better if the clock is done after power. > do you agree if I change the order? If the new ST variant can cope with the existing

Re: [PATCH 05/19] mmc: mmci: allow to overwrite clock/power procedure to specific variant

2018-07-11 Thread Ludovic BARRE
On 07/05/2018 03:48 PM, Ulf Hansson wrote: On 12 June 2018 at 15:14, Ludovic Barre wrote: From: Ludovic Barre A specific variant could have different power or clock procedures. This patch allows to overwrite the default mmci_set_clkreg and mmci_set_pwrreg for a specific variant.

Re: [PATCH 05/19] mmc: mmci: allow to overwrite clock/power procedure to specific variant

2018-07-11 Thread Ludovic BARRE
On 07/05/2018 03:48 PM, Ulf Hansson wrote: On 12 June 2018 at 15:14, Ludovic Barre wrote: From: Ludovic Barre A specific variant could have different power or clock procedures. This patch allows to overwrite the default mmci_set_clkreg and mmci_set_pwrreg for a specific variant.

Re: [PATCH 05/19] mmc: mmci: allow to overwrite clock/power procedure to specific variant

2018-07-05 Thread Ulf Hansson
On 12 June 2018 at 15:14, Ludovic Barre wrote: > From: Ludovic Barre > > A specific variant could have different power or clock procedures. > This patch allows to overwrite the default mmci_set_clkreg and > mmci_set_pwrreg for a specific variant. > > Signed-off-by: Ludovic Barre > --- >

Re: [PATCH 05/19] mmc: mmci: allow to overwrite clock/power procedure to specific variant

2018-07-05 Thread Ulf Hansson
On 12 June 2018 at 15:14, Ludovic Barre wrote: > From: Ludovic Barre > > A specific variant could have different power or clock procedures. > This patch allows to overwrite the default mmci_set_clkreg and > mmci_set_pwrreg for a specific variant. > > Signed-off-by: Ludovic Barre > --- >

[PATCH 05/19] mmc: mmci: allow to overwrite clock/power procedure to specific variant

2018-06-12 Thread Ludovic Barre
From: Ludovic Barre A specific variant could have different power or clock procedures. This patch allows to overwrite the default mmci_set_clkreg and mmci_set_pwrreg for a specific variant. Signed-off-by: Ludovic Barre --- drivers/mmc/host/mmci.c | 96

[PATCH 05/19] mmc: mmci: allow to overwrite clock/power procedure to specific variant

2018-06-12 Thread Ludovic Barre
From: Ludovic Barre A specific variant could have different power or clock procedures. This patch allows to overwrite the default mmci_set_clkreg and mmci_set_pwrreg for a specific variant. Signed-off-by: Ludovic Barre --- drivers/mmc/host/mmci.c | 96