Re: [PATCH 05/19] swim: use bdev_check_media_change

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Switch to use bdev_check_media_change instead of check_disk_change and > call floppy_revalidate manually. Given that floppy_revalidate only > deals with media change events, the extra call into ->revalidate_disk > from bdev_disk_changed is not required

[PATCH 05/19] swim: use bdev_check_media_change

2020-09-08 Thread Christoph Hellwig
Switch to use bdev_check_media_change instead of check_disk_change and call floppy_revalidate manually. Given that floppy_revalidate only deals with media change events, the extra call into ->revalidate_disk from bdev_disk_changed is not required either, so stop wiring up the method. Signed-off-b

Re: [PATCH 05/19] swim: use bdev_check_media_change

2020-09-02 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn > +static int floppy_revalidate(struct gendisk *disk); Completely unrelated to this series but, this is the 3rd floppy driver in the series defining it's own floppy_revalidate() and naming it floppy_revalidate(). This makes grepping and reviewing a

Re: [PATCH 05/19] swim: use bdev_check_media_change

2020-09-02 Thread Christoph Hellwig
On Wed, Sep 02, 2020 at 03:30:14PM +, Johannes Thumshirn wrote: > Looks good, > Reviewed-by: Johannes Thumshirn > > > +static int floppy_revalidate(struct gendisk *disk); > > Completely unrelated to this series but, this is the 3rd floppy > driver in the series defining it's own floppy_reva

[PATCH 05/19] swim: use bdev_check_media_change

2020-09-02 Thread Christoph Hellwig
Switch to use bdev_check_media_change instead of check_disk_change and call floppy_revalidate manually. Given that floppy_revalidate only deals with media change events, the extra call into ->revalidate_disk from bdev_disk_changed is not required either, so stop wiring up the method. Signed-off-b