Re: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-11 Thread Josh Poimboeuf
On Sun, Mar 10, 2019 at 02:19:29PM +0100, Peter Zijlstra wrote: > On Fri, Mar 08, 2019 at 01:03:34PM -0600, Josh Poimboeuf wrote: > > On Fri, Mar 08, 2019 at 01:00:38PM -0600, Josh Poimboeuf wrote: > > > On Thu, Mar 07, 2019 at 12:45:16PM +0100, Peter Zijlstra wrote: > > > > > XXX: arguably we sho

Re: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-10 Thread Peter Zijlstra
On Fri, Mar 08, 2019 at 01:03:34PM -0600, Josh Poimboeuf wrote: > On Fri, Mar 08, 2019 at 01:00:38PM -0600, Josh Poimboeuf wrote: > > On Thu, Mar 07, 2019 at 12:45:16PM +0100, Peter Zijlstra wrote: > > > XXX: arguably we should rename ANNOTATE_NOSPEC_ALTERNATIVE to > > > ANNOTATE_IGNORE_ALTER

Re: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-08 Thread Peter Zijlstra
On Fri, Mar 08, 2019 at 01:00:38PM -0600, Josh Poimboeuf wrote: > On Thu, Mar 07, 2019 at 12:45:16PM +0100, Peter Zijlstra wrote: > > drivers/xen/privcmd.o: warning: objtool: privcmd_ioctl()+0x1414: call to > > hypercall_page() with UACCESS enabled > > > > Xen needs to do HV calls with AC=1 for h

Re: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-08 Thread Josh Poimboeuf
On Fri, Mar 08, 2019 at 01:00:38PM -0600, Josh Poimboeuf wrote: > On Thu, Mar 07, 2019 at 12:45:16PM +0100, Peter Zijlstra wrote: > > drivers/xen/privcmd.o: warning: objtool: privcmd_ioctl()+0x1414: call to > > hypercall_page() with UACCESS enabled > > > > Xen needs to do HV calls with AC=1 for h

Re: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-08 Thread Josh Poimboeuf
On Thu, Mar 07, 2019 at 12:45:16PM +0100, Peter Zijlstra wrote: > drivers/xen/privcmd.o: warning: objtool: privcmd_ioctl()+0x1414: call to > hypercall_page() with UACCESS enabled > > Xen needs to do HV calls with AC=1 for hysterical raisins. Make the > warning go away. > > XXX: arguably we shoul

Re: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-07 Thread Juergen Gross
On 07/03/2019 13:32, Peter Zijlstra wrote: > On Thu, Mar 07, 2019 at 01:22:52PM +0100, Juergen Gross wrote: >> On 07/03/2019 12:45, Peter Zijlstra wrote: >>> drivers/xen/privcmd.o: warning: objtool: privcmd_ioctl()+0x1414: call to >>> hypercall_page() with UACCESS enabled >>> >>> Xen needs to do H

Re: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-07 Thread Peter Zijlstra
On Thu, Mar 07, 2019 at 01:22:52PM +0100, Juergen Gross wrote: > On 07/03/2019 12:45, Peter Zijlstra wrote: > > drivers/xen/privcmd.o: warning: objtool: privcmd_ioctl()+0x1414: call to > > hypercall_page() with UACCESS enabled > > > > Xen needs to do HV calls with AC=1 for hysterical raisins. Mak

Re: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-07 Thread Juergen Gross
On 07/03/2019 12:45, Peter Zijlstra wrote: > drivers/xen/privcmd.o: warning: objtool: privcmd_ioctl()+0x1414: call to > hypercall_page() with UACCESS enabled > > Xen needs to do HV calls with AC=1 for hysterical raisins. Make the > warning go away. No, this is a hypercall with parameters passed

[PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-07 Thread Peter Zijlstra
drivers/xen/privcmd.o: warning: objtool: privcmd_ioctl()+0x1414: call to hypercall_page() with UACCESS enabled Xen needs to do HV calls with AC=1 for hysterical raisins. Make the warning go away. XXX: arguably we should rename ANNOTATE_NOSPEC_ALTERNATIVE to ANNOTATE_IGNORE_ALTERNATIVE. Cc: