Re: [PATCH 05/21] iio: input: am335x_adc: Add continuous mode to adc

2013-07-18 Thread Felipe Balbi
Hi, On Wed, Jul 17, 2013 at 06:26:34PM +0100, Zubair Lutfullah wrote: > Main patch. Adds continuous sampling support for the driver > > The IRQs are changed in the TSC drivers as they are shared with > the ADC IRQ lines. > > This patch is based on work in the 3.2 tree by TI > Original Author is

Re: [PATCH 05/21] iio: input: am335x_adc: Add continuous mode to adc

2013-07-17 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Jul 17, 2013 at 06:53:53PM +0100, Zubair Lutfullah wrote: > checkpatch is applied at the end all together. The last 3 patches are those. > > I guess that is non-standard practice. Yes, each

Re: [PATCH 05/21] iio: input: am335x_adc: Add continuous mode to adc

2013-07-17 Thread Greg KH
On Wed, Jul 17, 2013 at 06:26:34PM +0100, Zubair Lutfullah wrote: > Main patch. Adds continuous sampling support for the driver What does that mean? Why have this in the changelog at all? > > The IRQs are changed in the TSC drivers as they are shared with > the ADC IRQ lines. > > This patch is

[PATCH 05/21] iio: input: am335x_adc: Add continuous mode to adc

2013-07-17 Thread Zubair Lutfullah
Main patch. Adds continuous sampling support for the driver The IRQs are changed in the TSC drivers as they are shared with the ADC IRQ lines. This patch is based on work in the 3.2 tree by TI Original Author is Patil Rachna Signed-off-by: Zubair Lutfullah --- drivers/iio/adc/ti_am335x_adc.c