Re: [PATCH 05/25] ubifs: implement ubifs_lpt_lookup using ubifs_pnode_lookup

On Mon, Aug 13, 2018 at 8:31 AM Sascha Hauer wrote: > > On Wed, Jul 04, 2018 at 02:41:17PM +0200, Sascha Hauer wrote: > > ubifs_lpt_lookup() starts by looking up the nth pnode in the LPT. We > > already have this functionality in ubifs_pnode_lookup(). Use this > > function rather than open coding

Re: [PATCH 05/25] ubifs: implement ubifs_lpt_lookup using ubifs_pnode_lookup

Am Montag, 13. August 2018, 10:12:38 CEST schrieb Sascha Hauer: > > Can you please add a helper function for that? These shift games are > > always confusing and not easy to spot. > > Do you have a suggestion for a helper function? lpt.c is full of rather > non obvious arithmetic operations and I

Re: [PATCH 05/25] ubifs: implement ubifs_lpt_lookup using ubifs_pnode_lookup

On Mon, Aug 13, 2018 at 08:34:00AM +0200, Richard Weinberger wrote: > Am Montag, 13. August 2018, 08:31:27 CEST schrieb Sascha Hauer: > > On Wed, Jul 04, 2018 at 02:41:17PM +0200, Sascha Hauer wrote: > > > ubifs_lpt_lookup() starts by looking up the nth pnode in the LPT. We > > > already have this

Re: [PATCH 05/25] ubifs: implement ubifs_lpt_lookup using ubifs_pnode_lookup

Am Montag, 13. August 2018, 08:31:27 CEST schrieb Sascha Hauer: > On Wed, Jul 04, 2018 at 02:41:17PM +0200, Sascha Hauer wrote: > > ubifs_lpt_lookup() starts by looking up the nth pnode in the LPT. We > > already have this functionality in ubifs_pnode_lookup(). Use this > > function rather than ope

Re: [PATCH 05/25] ubifs: implement ubifs_lpt_lookup using ubifs_pnode_lookup

On Wed, Jul 04, 2018 at 02:41:17PM +0200, Sascha Hauer wrote: > ubifs_lpt_lookup() starts by looking up the nth pnode in the LPT. We > already have this functionality in ubifs_pnode_lookup(). Use this > function rather than open coding its functionality. > > Signed-off-by: Sascha Hauer > --- > f

[PATCH 05/25] ubifs: implement ubifs_lpt_lookup using ubifs_pnode_lookup

ubifs_lpt_lookup() starts by looking up the nth pnode in the LPT. We already have this functionality in ubifs_pnode_lookup(). Use this function rather than open coding its functionality. Signed-off-by: Sascha Hauer --- fs/ubifs/lpt.c | 20 ++-- 1 file changed, 2 insertions(+), 18