Re: [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value

2020-10-20 Thread Martin Blumenstingl
On Tue, Oct 20, 2020 at 2:00 PM Serge Semin wrote: > > In accordance with the DWC USB3 bindings the property is supposed to have > uint32 type. It's erroneous from the DT schema and driver points of view > to declare it as boolean. As Neil suggested set it to 0x20 so not break > the platform and

Re: [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value

2020-10-20 Thread Neil Armstrong
Hi Serge, On 20/10/2020 13:59, Serge Semin wrote: > In accordance with the DWC USB3 bindings the property is supposed to have > uint32 type. It's erroneous from the DT schema and driver points of view > to declare it as boolean. As Neil suggested set it to 0x20 so not break > the platform and to

Re: [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value

2020-10-20 Thread Krzysztof Kozlowski
On Tue, Oct 20, 2020 at 03:44:04PM +0300, Serge Semin wrote: > On Tue, Oct 20, 2020 at 02:34:04PM +0200, Krzysztof Kozlowski wrote: > > On Tue, Oct 20, 2020 at 02:59:35PM +0300, Serge Semin wrote: > > > In accordance with the DWC USB3 bindings the property is supposed to have > > > uint32 type.

Re: [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value

2020-10-20 Thread Serge Semin
On Tue, Oct 20, 2020 at 02:34:04PM +0200, Krzysztof Kozlowski wrote: > On Tue, Oct 20, 2020 at 02:59:35PM +0300, Serge Semin wrote: > > In accordance with the DWC USB3 bindings the property is supposed to have > > uint32 type. It's erroneous from the DT schema and driver points of view > > to

Re: [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value

2020-10-20 Thread Krzysztof Kozlowski
On Tue, Oct 20, 2020 at 02:59:35PM +0300, Serge Semin wrote: > In accordance with the DWC USB3 bindings the property is supposed to have > uint32 type. It's erroneous from the DT schema and driver points of view > to declare it as boolean. I think the driver uses it as u32, so what do you mean by

[PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value

2020-10-20 Thread Serge Semin
In accordance with the DWC USB3 bindings the property is supposed to have uint32 type. It's erroneous from the DT schema and driver points of view to declare it as boolean. As Neil suggested set it to 0x20 so not break the platform and to make the dtbs checker happy. Link: