Re: [PATCH 05/39] vfs: optionally don't account file in nr_files

2018-06-09 Thread Al Viro
On Tue, May 29, 2018 at 04:43:05PM +0200, Miklos Szeredi wrote: > +++ b/fs/open.c > @@ -732,8 +732,8 @@ static int do_dentry_open(struct file *f, > static const struct file_operations empty_fops = {}; > int error; > > - f->f_mode = OPEN_FMODE(f->f_flags) | FMODE_LSEEK | > -

Re: [PATCH 05/39] vfs: optionally don't account file in nr_files

2018-06-04 Thread Miklos Szeredi
On Mon, Jun 4, 2018 at 10:47 AM, Christoph Hellwig wrote: > On Tue, May 29, 2018 at 04:43:05PM +0200, Miklos Szeredi wrote: >> Stacking file operations in overlay will store an extra open file for each >> overlay file opened. >> >> The overhead is just that of "struct file" which is about 256bytes

Re: [PATCH 05/39] vfs: optionally don't account file in nr_files

2018-06-04 Thread Christoph Hellwig
On Tue, May 29, 2018 at 04:43:05PM +0200, Miklos Szeredi wrote: > Stacking file operations in overlay will store an extra open file for each > overlay file opened. > > The overhead is just that of "struct file" which is about 256bytes, because > overlay already pins an extra dentry and inode when

[PATCH 05/39] vfs: optionally don't account file in nr_files

2018-05-29 Thread Miklos Szeredi
Stacking file operations in overlay will store an extra open file for each overlay file opened. The overhead is just that of "struct file" which is about 256bytes, because overlay already pins an extra dentry and inode when the file is open, which add up to a much larger overhead. For fear of bre