Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function

2016-09-21 Thread Jiri Olsa
On Wed, Sep 21, 2016 at 11:16:26AM -0400, Don Zickus wrote: > On Wed, Sep 21, 2016 at 11:18:29AM +0200, Jiri Olsa wrote: > > On Wed, Sep 21, 2016 at 09:08:40AM +, Stanislav Ievlev wrote: > > > Hi, Jiri! > > > > > > Why are you not using unsigned integer for counters in c2c_stats > > > structu

Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function

2016-09-21 Thread Don Zickus
On Wed, Sep 21, 2016 at 11:18:29AM +0200, Jiri Olsa wrote: > On Wed, Sep 21, 2016 at 09:08:40AM +, Stanislav Ievlev wrote: > > Hi, Jiri! > > > > Why are you not using unsigned integer for counters in c2c_stats structure? > > hi, > never really thought of that, because that's one of the origin

Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function

2016-09-21 Thread Jiri Olsa
On Wed, Sep 21, 2016 at 09:08:40AM +, Stanislav Ievlev wrote: > Hi, Jiri! > > Why are you not using unsigned integer for counters in c2c_stats structure? hi, never really thought of that, because that's one of the original patches I could take almost untouched.. so no real reason ;-) jirka

Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function

2016-09-19 Thread Joe Mario
On 09/19/2016 01:15 PM, Nilay Vaish wrote: On 19 September 2016 at 08:09, Jiri Olsa wrote: diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h index 7f69bf9d789d..27c6bb5abafb 100644 --- a/tools/perf/util/mem-events.h +++ b/tools/perf/util/mem-events.h @@ -2,6 +2,10 @@ #de

Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function

2016-09-19 Thread Nilay Vaish
On 19 September 2016 at 08:09, Jiri Olsa wrote: > diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h > index 7f69bf9d789d..27c6bb5abafb 100644 > --- a/tools/perf/util/mem-events.h > +++ b/tools/perf/util/mem-events.h > @@ -2,6 +2,10 @@ > #define __PERF_MEM_EVENTS_H > > #inc

[PATCH 05/61] perf tools: Introduce c2c_decode_stats function

2016-09-19 Thread Jiri Olsa
Introducing c2c_decode_stats function, which decodes data_src data into new struct c2c_stats. Original-patch-by: Dick Fowles Original-patch-by: Don Zickus Link: http://lkml.kernel.org/n/tip-7garqfmx5izaqysde9jik...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/mem-events.c | 98 +