Re: [PATCH 06/10] ALSA: axd: add basic files for sending/receiving axd cmds

2015-09-03 Thread Mark Brown
On Tue, Sep 01, 2015 at 11:46:19AM +0100, Qais Yousef wrote: > On 08/29/2015 11:18 AM, Mark Brown wrote: > >On Thu, Aug 27, 2015 at 04:40:09PM +0100, Qais Yousef wrote: Again, please delete unneeded contexts and leave blanks between paragraphs (I notice you've even been removing the blank lines

Re: [PATCH 06/10] ALSA: axd: add basic files for sending/receiving axd cmds

2015-09-03 Thread Mark Brown
On Tue, Sep 01, 2015 at 11:46:19AM +0100, Qais Yousef wrote: > On 08/29/2015 11:18 AM, Mark Brown wrote: > >On Thu, Aug 27, 2015 at 04:40:09PM +0100, Qais Yousef wrote: Again, please delete unneeded contexts and leave blanks between paragraphs (I notice you've even been removing the blank lines

Re: [PATCH 06/10] ALSA: axd: add basic files for sending/receiving axd cmds

2015-09-01 Thread Qais Yousef
On 08/29/2015 11:18 AM, Mark Brown wrote: On Thu, Aug 27, 2015 at 04:40:09PM +0100, Qais Yousef wrote: On 08/26/2015 08:16 PM, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:39:15PM +0100, Qais Yousef wrote: +unsigned long axd_cmd_get_datain_address(struct axd_cmd *cmd) +{ + struct

Re: [PATCH 06/10] ALSA: axd: add basic files for sending/receiving axd cmds

2015-09-01 Thread Qais Yousef
On 08/29/2015 11:18 AM, Mark Brown wrote: On Thu, Aug 27, 2015 at 04:40:09PM +0100, Qais Yousef wrote: On 08/26/2015 08:16 PM, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:39:15PM +0100, Qais Yousef wrote: +unsigned long axd_cmd_get_datain_address(struct axd_cmd *cmd) +{ + struct

Re: [PATCH 06/10] ALSA: axd: add basic files for sending/receiving axd cmds

2015-08-29 Thread Mark Brown
On Thu, Aug 27, 2015 at 04:40:09PM +0100, Qais Yousef wrote: > On 08/26/2015 08:16 PM, Mark Brown wrote: > >On Mon, Aug 24, 2015 at 01:39:15PM +0100, Qais Yousef wrote: > >>+unsigned long axd_cmd_get_datain_address(struct axd_cmd *cmd) > >>+{ > >>+ struct axd_dev *axd = container_of(cmd,

Re: [PATCH 06/10] ALSA: axd: add basic files for sending/receiving axd cmds

2015-08-29 Thread Mark Brown
On Thu, Aug 27, 2015 at 04:40:09PM +0100, Qais Yousef wrote: On 08/26/2015 08:16 PM, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:39:15PM +0100, Qais Yousef wrote: +unsigned long axd_cmd_get_datain_address(struct axd_cmd *cmd) +{ + struct axd_dev *axd = container_of(cmd, struct axd_dev,

Re: [PATCH 06/10] ALSA: axd: add basic files for sending/receiving axd cmds

2015-08-27 Thread Qais Yousef
On 08/26/2015 08:16 PM, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:39:15PM +0100, Qais Yousef wrote: +int axd_cmd_set_pc(struct axd_cmd *cmd, unsigned int thread, unsigned long pc) +{ + if (thread >= THREAD_COUNT) + return -1; Return sensible error codes please. OK.

Re: [PATCH 06/10] ALSA: axd: add basic files for sending/receiving axd cmds

2015-08-27 Thread Qais Yousef
On 08/26/2015 08:16 PM, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:39:15PM +0100, Qais Yousef wrote: +int axd_cmd_set_pc(struct axd_cmd *cmd, unsigned int thread, unsigned long pc) +{ + if (thread = THREAD_COUNT) + return -1; Return sensible error codes please. OK.

Re: [PATCH 06/10] ALSA: axd: add basic files for sending/receiving axd cmds

2015-08-26 Thread Mark Brown
On Mon, Aug 24, 2015 at 01:39:15PM +0100, Qais Yousef wrote: > +int axd_cmd_set_pc(struct axd_cmd *cmd, unsigned int thread, unsigned long > pc) > +{ > + if (thread >= THREAD_COUNT) > + return -1; Return sensible error codes please. > +unsigned long

Re: [PATCH 06/10] ALSA: axd: add basic files for sending/receiving axd cmds

2015-08-26 Thread Mark Brown
On Mon, Aug 24, 2015 at 01:39:15PM +0100, Qais Yousef wrote: +int axd_cmd_set_pc(struct axd_cmd *cmd, unsigned int thread, unsigned long pc) +{ + if (thread = THREAD_COUNT) + return -1; Return sensible error codes please. +unsigned long axd_cmd_get_datain_address(struct

[PATCH 06/10] ALSA: axd: add basic files for sending/receiving axd cmds

2015-08-24 Thread Qais Yousef
These files do the important part of talking with AXD to send and receive data buffers. Signed-off-by: Qais Yousef Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: linux-kernel@vger.kernel.org --- sound/soc/img/axd/axd_cmds.c | 102 +++

[PATCH 06/10] ALSA: axd: add basic files for sending/receiving axd cmds

2015-08-24 Thread Qais Yousef
These files do the important part of talking with AXD to send and receive data buffers. Signed-off-by: Qais Yousef qais.you...@imgtec.com Cc: Liam Girdwood lgirdw...@gmail.com Cc: Mark Brown broo...@kernel.org Cc: Jaroslav Kysela pe...@perex.cz Cc: Takashi Iwai ti...@suse.com Cc: