Re: [PATCH 06/10] mm/hugetlb: remove redundant huge_pte_alloc() in hugetlb_fault()

2020-08-10 Thread Mike Kravetz
On 8/7/20 2:12 AM, Wei Yang wrote: > Before proper processing, huge_pte_alloc() would be called > un-conditionally. It is not necessary to do this when ptep is NULL. Worse, that extra call is a bug. I believe Andrew pulled this patch into his queue. It still could use a review. https://lore.ker

Re: [PATCH 06/10] mm/hugetlb: remove redundant huge_pte_alloc() in hugetlb_fault()

2020-08-07 Thread Baoquan He
On 08/07/20 at 05:12pm, Wei Yang wrote: > Before proper processing, huge_pte_alloc() would be called > un-conditionally. It is not necessary to do this when ptep is NULL. > > Signed-off-by: Wei Yang > --- > mm/hugetlb.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/mm/hugetlb.c b/

[PATCH 06/10] mm/hugetlb: remove redundant huge_pte_alloc() in hugetlb_fault()

2020-08-07 Thread Wei Yang
Before proper processing, huge_pte_alloc() would be called un-conditionally. It is not necessary to do this when ptep is NULL. Signed-off-by: Wei Yang --- mm/hugetlb.c | 4 1 file changed, 4 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index f5f04e89000d..fb09e5a83c39 100644 --- a