Re: [PATCH 06/11] fblog: open fb on registration

2012-08-14 Thread David Herrmann
Hi Ryan On Mon, Aug 13, 2012 at 2:00 AM, Ryan Mallon wrote: > On 13/08/12 00:53, David Herrmann wrote: >> /* >> + * fblog_open/close() >> + * These functions manage access to the underlying framebuffer. While >> opened, we >> + * have a valid reference to the fb and can use it for drawing opera

Re: [PATCH 06/11] fblog: open fb on registration

2012-08-12 Thread Ryan Mallon
On 13/08/12 00:53, David Herrmann wrote: > This opens the framebuffer upon registration so we can use it for > drawing-operations. On unregistration we close it again. > > While opening/closing or accessing the fb in any other way, we must hold > the fb-mutex. However, since the notifiers are ofte

[PATCH 06/11] fblog: open fb on registration

2012-08-12 Thread David Herrmann
This opens the framebuffer upon registration so we can use it for drawing-operations. On unregistration we close it again. While opening/closing or accessing the fb in any other way, we must hold the fb-mutex. However, since the notifiers are often called with the mutex already held, we cannot loc