Re: [PATCH 06/11] irqchip: mips-cpu: Drop unnecessary static

2017-07-15 Thread Mark D Rustad
> On Jul 15, 2017, at 1:59 PM, Julia Lawall wrote: > > On Sat, 15 Jul 2017, Mark D Rustad wrote: > >> >>> On Jul 15, 2017, at 1:07 PM, Julia Lawall wrote: >>> >>> Drop static on a local variable, when the variable is initialized before >>> any possible use. Thus, the static has no benefit. >

Re: [PATCH 06/11] irqchip: mips-cpu: Drop unnecessary static

2017-07-15 Thread Julia Lawall
On Sat, 15 Jul 2017, Mark D Rustad wrote: > > > On Jul 15, 2017, at 1:07 PM, Julia Lawall wrote: > > > > Drop static on a local variable, when the variable is initialized before > > any possible use. Thus, the static has no benefit. > > I think this is in error like the other one. I believe th

Re: [PATCH 06/11] irqchip: mips-cpu: Drop unnecessary static

2017-07-15 Thread Mark D Rustad
> On Jul 15, 2017, at 1:07 PM, Julia Lawall wrote: > > Drop static on a local variable, when the variable is initialized before > any possible use. Thus, the static has no benefit. I think this is in error like the other one. I believe that the irq_chip structure needs a persistent lifetime.

[PATCH 06/11] irqchip: mips-cpu: Drop unnecessary static

2017-07-15 Thread Julia Lawall
Drop static on a local variable, when the variable is initialized before any possible use. Thus, the static has no benefit. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...