Re: [PATCH 06/11] media: exynos4-is: Properly set JPEG options when not using CSIS

2020-07-11 Thread Jonathan Bakker
Hi Sylwester and Tomasz, On 2020-07-08 8:45 a.m., Sylwester Nawrocki wrote: > Hi, > > On 07.07.2020 20:23, Tomasz Figa wrote: >> On Sat, Apr 25, 2020 at 07:26:45PM -0700, Jonathan Bakker wrote: >>> Commit ee7160e57c98 ("[media] s5p-fimc: Add support for JPEG capture") >>> added support for JPEG c

Re: [PATCH 06/11] media: exynos4-is: Properly set JPEG options when not using CSIS

2020-07-08 Thread Sylwester Nawrocki
On 26.04.2020 04:26, Jonathan Bakker wrote: > Commit ee7160e57c98 ("[media] s5p-fimc: Add support for JPEG capture") > added support for JPEG capture, but missed setting a register when the > CSIS device wasn't in use. > > Signed-off-by: Jonathan Bakker Reviewed-by: Sylwester Nawrocki

Re: [PATCH 06/11] media: exynos4-is: Properly set JPEG options when not using CSIS

2020-07-08 Thread Sylwester Nawrocki
Hi, On 07.07.2020 20:23, Tomasz Figa wrote: > On Sat, Apr 25, 2020 at 07:26:45PM -0700, Jonathan Bakker wrote: >> Commit ee7160e57c98 ("[media] s5p-fimc: Add support for JPEG capture") >> added support for JPEG capture, but missed setting a register when the >> CSIS device wasn't in use. > nit: S

Re: [PATCH 06/11] media: exynos4-is: Properly set JPEG options when not using CSIS

2020-07-07 Thread Tomasz Figa
Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:45PM -0700, Jonathan Bakker wrote: > Commit ee7160e57c98 ("[media] s5p-fimc: Add support for JPEG capture") > added support for JPEG capture, but missed setting a register when the > CSIS device wasn't in use. nit: Since this isn't really about using the