Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2013-01-06 Thread Rusty Russell
Tejun Heo writes: > Hello, Rusty. > > On Thu, Jan 03, 2013 at 11:17:11AM +1030, Rusty Russell wrote: >> > So, I guess this currently is caught in a place which isn't here or >> > there. I'm pretty skeptical whether it makes sense to bother about >> > static usages tho. Can I keep them for

Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2013-01-06 Thread Rusty Russell
Tejun Heo t...@kernel.org writes: Hello, Rusty. On Thu, Jan 03, 2013 at 11:17:11AM +1030, Rusty Russell wrote: So, I guess this currently is caught in a place which isn't here or there. I'm pretty skeptical whether it makes sense to bother about static usages tho. Can I keep them for

[PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2013-01-03 Thread Tejun Heo
cpuset_can_attach() prepare global variables cpus_attach and cpuset_attach_nodemask_{to|from} which are used by cpuset_attach(). There is no reason to prepare in cpuset_can_attach(). The same information can be accessed from cpuset_attach(). Move the prepartion logic from cpuset_can_attach() to

[PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2013-01-03 Thread Tejun Heo
cpuset_can_attach() prepare global variables cpus_attach and cpuset_attach_nodemask_{to|from} which are used by cpuset_attach(). There is no reason to prepare in cpuset_can_attach(). The same information can be accessed from cpuset_attach(). Move the prepartion logic from cpuset_can_attach() to

Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2013-01-02 Thread Tejun Heo
Hello, Rusty. On Thu, Jan 03, 2013 at 11:17:11AM +1030, Rusty Russell wrote: > > So, I guess this currently is caught in a place which isn't here or > > there. I'm pretty skeptical whether it makes sense to bother about > > static usages tho. Can I keep them for static ones? > > I didn't

Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2013-01-02 Thread Rusty Russell
Tejun Heo writes: > Hello, Rusty. > > On Wed, Jan 02, 2013 at 03:12:15PM +1030, Rusty Russell wrote: >> > Hmmm? cpumask_t can't be used for stack but other than that I don't >> > see how it would be deprecated completely. Rusty, can you please >> > chime in? >> >> The

Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2013-01-02 Thread Tejun Heo
Hello, Rusty. On Wed, Jan 02, 2013 at 03:12:15PM +1030, Rusty Russell wrote: > > Hmmm? cpumask_t can't be used for stack but other than that I don't > > see how it would be deprecated completely. Rusty, can you please > > chime in? > > The long-never-quite-complete-plan was for struct cpumask

Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2013-01-02 Thread Tejun Heo
Hello, Rusty. On Wed, Jan 02, 2013 at 03:12:15PM +1030, Rusty Russell wrote: Hmmm? cpumask_t can't be used for stack but other than that I don't see how it would be deprecated completely. Rusty, can you please chime in? The long-never-quite-complete-plan was for struct cpumask to be

Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2013-01-02 Thread Rusty Russell
Tejun Heo t...@kernel.org writes: Hello, Rusty. On Wed, Jan 02, 2013 at 03:12:15PM +1030, Rusty Russell wrote: Hmmm? cpumask_t can't be used for stack but other than that I don't see how it would be deprecated completely. Rusty, can you please chime in? The

Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2013-01-02 Thread Tejun Heo
Hello, Rusty. On Thu, Jan 03, 2013 at 11:17:11AM +1030, Rusty Russell wrote: So, I guess this currently is caught in a place which isn't here or there. I'm pretty skeptical whether it makes sense to bother about static usages tho. Can I keep them for static ones? I didn't realize that

Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2013-01-01 Thread Rusty Russell
Tejun Heo writes: > (cc'ing Rusty, hi!) > > Hello, Li. > > On Wed, Dec 26, 2012 at 06:20:11PM +0800, Li Zefan wrote: >> On 2012/11/29 5:34, Tejun Heo wrote: >> > cpuset_can_attach() prepare global variables cpus_attach and >> > cpuset_attach_nodemask_{to|from} which are used by cpuset_attach().

Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2013-01-01 Thread Rusty Russell
Tejun Heo t...@kernel.org writes: (cc'ing Rusty, hi!) Hello, Li. On Wed, Dec 26, 2012 at 06:20:11PM +0800, Li Zefan wrote: On 2012/11/29 5:34, Tejun Heo wrote: cpuset_can_attach() prepare global variables cpus_attach and cpuset_attach_nodemask_{to|from} which are used by

Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2012-12-26 Thread Tejun Heo
(cc'ing Rusty, hi!) Hello, Li. On Wed, Dec 26, 2012 at 06:20:11PM +0800, Li Zefan wrote: > On 2012/11/29 5:34, Tejun Heo wrote: > > cpuset_can_attach() prepare global variables cpus_attach and > > cpuset_attach_nodemask_{to|from} which are used by cpuset_attach(). > > There is no reason to

Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2012-12-26 Thread Li Zefan
On 2012/11/29 5:34, Tejun Heo wrote: > cpuset_can_attach() prepare global variables cpus_attach and > cpuset_attach_nodemask_{to|from} which are used by cpuset_attach(). > There is no reason to prepare in cpuset_can_attach(). The same > information can be accessed from cpuset_attach(). > > Move

Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2012-12-26 Thread Li Zefan
On 2012/11/29 5:34, Tejun Heo wrote: cpuset_can_attach() prepare global variables cpus_attach and cpuset_attach_nodemask_{to|from} which are used by cpuset_attach(). There is no reason to prepare in cpuset_can_attach(). The same information can be accessed from cpuset_attach(). Move the

Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2012-12-26 Thread Tejun Heo
(cc'ing Rusty, hi!) Hello, Li. On Wed, Dec 26, 2012 at 06:20:11PM +0800, Li Zefan wrote: On 2012/11/29 5:34, Tejun Heo wrote: cpuset_can_attach() prepare global variables cpus_attach and cpuset_attach_nodemask_{to|from} which are used by cpuset_attach(). There is no reason to prepare in

[PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2012-11-28 Thread Tejun Heo
cpuset_can_attach() prepare global variables cpus_attach and cpuset_attach_nodemask_{to|from} which are used by cpuset_attach(). There is no reason to prepare in cpuset_can_attach(). The same information can be accessed from cpuset_attach(). Move the prepartion logic from cpuset_can_attach() to

[PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()

2012-11-28 Thread Tejun Heo
cpuset_can_attach() prepare global variables cpus_attach and cpuset_attach_nodemask_{to|from} which are used by cpuset_attach(). There is no reason to prepare in cpuset_can_attach(). The same information can be accessed from cpuset_attach(). Move the prepartion logic from cpuset_can_attach() to