Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-17 Thread Kees Cook
On Thu, Sep 17, 2020 at 11:35:40AM +, George Popescu wrote: > On Thu, Sep 17, 2020 at 08:37:07AM +0200, Marco Elver wrote: > > So, it seems that local-bounds can still catch some rare OOB accesses, > > where KASAN fails to catch it because the access might skip over the > > redzone. > > > > Th

Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-17 Thread Kees Cook
On Tue, Sep 15, 2020 at 10:24:58AM +, George Popescu wrote: > This would mean losing the local-bounds coverage. I tried to test it without > local-bounds and with a locally defined array on the stack and it works fine > (the handler is called and the error reported). For me it feels like > --a

Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-17 Thread George Popescu
On Thu, Sep 17, 2020 at 08:37:07AM +0200, Marco Elver wrote: > On Wed, 16 Sep 2020 at 15:40, Marco Elver wrote: > > On Wed, Sep 16, 2020 at 12:14PM +, George Popescu wrote: > > > On Wed, Sep 16, 2020 at 10:32:40AM +0200, Marco Elver wrote: > > > > On Wed, 16 Sep 2020 at 09:40, George Popescu

Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-16 Thread Marco Elver
On Wed, 16 Sep 2020 at 15:40, Marco Elver wrote: > On Wed, Sep 16, 2020 at 12:14PM +, George Popescu wrote: > > On Wed, Sep 16, 2020 at 10:32:40AM +0200, Marco Elver wrote: > > > On Wed, 16 Sep 2020 at 09:40, George Popescu > > > wrote: > > > > On Tue, Sep 15, 2020 at 07:32:28PM +0200, Marco

Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-16 Thread Marco Elver
On Wed, Sep 16, 2020 at 12:14PM +, George Popescu wrote: > On Wed, Sep 16, 2020 at 10:32:40AM +0200, Marco Elver wrote: > > On Wed, 16 Sep 2020 at 09:40, George Popescu wrote: > > > On Tue, Sep 15, 2020 at 07:32:28PM +0200, Marco Elver wrote: > > > > On Tue, 15 Sep 2020 at 14:01, George Popesc

Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-16 Thread Marco Elver
On Wed, 16 Sep 2020 at 09:40, George Popescu wrote: > > On Tue, Sep 15, 2020 at 07:32:28PM +0200, Marco Elver wrote: > > On Tue, 15 Sep 2020 at 14:01, George Popescu wrote: > > > > > > On Tue, Sep 15, 2020 at 01:18:11PM +0200, Marco Elver wrote: > > > > On Tue, 15 Sep 2020 at 12:25, George Popesc

Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-16 Thread George Popescu
On Tue, Sep 15, 2020 at 07:32:28PM +0200, Marco Elver wrote: > On Tue, 15 Sep 2020 at 14:01, George Popescu wrote: > > > > On Tue, Sep 15, 2020 at 01:18:11PM +0200, Marco Elver wrote: > > > On Tue, 15 Sep 2020 at 12:25, George Popescu > > > wrote: > > > > On Mon, Sep 14, 2020 at 03:13:14PM -0700

Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-15 Thread Marco Elver
On Tue, 15 Sep 2020 at 14:01, George Popescu wrote: > > On Tue, Sep 15, 2020 at 01:18:11PM +0200, Marco Elver wrote: > > On Tue, 15 Sep 2020 at 12:25, George Popescu wrote: > > > On Mon, Sep 14, 2020 at 03:13:14PM -0700, Kees Cook wrote: > > > > On Mon, Sep 14, 2020 at 05:27:42PM +, George-Au

Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-15 Thread George Popescu
On Tue, Sep 15, 2020 at 01:18:11PM +0200, Marco Elver wrote: > On Tue, 15 Sep 2020 at 12:25, George Popescu wrote: > > On Mon, Sep 14, 2020 at 03:13:14PM -0700, Kees Cook wrote: > > > On Mon, Sep 14, 2020 at 05:27:42PM +, George-Aurelian Popescu wrote: > > > > From: George Popescu > > > > > >

Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-15 Thread Marco Elver
On Tue, 15 Sep 2020 at 12:25, George Popescu wrote: > On Mon, Sep 14, 2020 at 03:13:14PM -0700, Kees Cook wrote: > > On Mon, Sep 14, 2020 at 05:27:42PM +, George-Aurelian Popescu wrote: > > > From: George Popescu > > > > > > When the kernel is compiled with Clang, UBSAN_BOUNDS inserts a brk a

Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-15 Thread George Popescu
On Mon, Sep 14, 2020 at 03:13:14PM -0700, Kees Cook wrote: > On Mon, Sep 14, 2020 at 05:27:42PM +, George-Aurelian Popescu wrote: > > From: George Popescu > > > > When the kernel is compiled with Clang, UBSAN_BOUNDS inserts a brk after > > the handler call, preventing it from printing any inf

Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-14 Thread Kees Cook
On Mon, Sep 14, 2020 at 05:27:42PM +, George-Aurelian Popescu wrote: > From: George Popescu > > When the kernel is compiled with Clang, UBSAN_BOUNDS inserts a brk after > the handler call, preventing it from printing any information processed > inside the buffer. > For Clang -fsanitize=bounds

Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-14 Thread Nick Desaulniers
+ kernel-dynamic-tools to help review. On Mon, Sep 14, 2020 at 10:28 AM George-Aurelian Popescu wrote: > > From: George Popescu > > When the kernel is compiled with Clang, UBSAN_BOUNDS inserts a brk after > the handler call, preventing it from printing any information processed > inside the buff

[PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang

2020-09-14 Thread George-Aurelian Popescu
From: George Popescu When the kernel is compiled with Clang, UBSAN_BOUNDS inserts a brk after the handler call, preventing it from printing any information processed inside the buffer. For Clang -fsanitize=bounds expands to -fsanitize=array-bounds and -fsanitize=local-bounds, and the latter adds