Re: [PATCH 06/16] ia64: fix up obsolete cpu function usage.

2015-05-27 Thread Rusty Russell
Tony Luck writes: > On Tue, May 26, 2015 at 6:18 PM, Rusty Russell wrote: > >> cpumask_test_cpu() doesn't take volatile, unlike the obsoleted >> cpu_isset. The only place ia64 really cares is the spin waiting for a >> bit; udelay() is probably a barrier but insert rmb() to be sure. > > Good to b

Re: [PATCH 06/16] ia64: fix up obsolete cpu function usage.

2015-05-27 Thread Tony Luck
On Tue, May 26, 2015 at 6:18 PM, Rusty Russell wrote: > cpumask_test_cpu() doesn't take volatile, unlike the obsoleted > cpu_isset. The only place ia64 really cares is the spin waiting for a > bit; udelay() is probably a barrier but insert rmb() to be sure. Good to be sure ... but cpumask_test_

Re: [PATCH 06/16] ia64: fix up obsolete cpu function usage.

2015-05-26 Thread Rusty Russell
Tony Luck writes: > On Mon, Mar 2, 2015 at 3:35 AM, Rusty Russell wrote: >> Thanks to spatch, then a sweep for for_each_cpu_mask => for_each_cpu. >> >> Signed-off-by: Rusty Russell > > I'm seeing a bunch of warnings building the ia64 tree: Indeed, here's the forgotten fix sitting in my patch co

Re: [PATCH 06/16] ia64: fix up obsolete cpu function usage.

2015-05-26 Thread Tony Luck
On Mon, Mar 2, 2015 at 3:35 AM, Rusty Russell wrote: > Thanks to spatch, then a sweep for for_each_cpu_mask => for_each_cpu. > > Signed-off-by: Rusty Russell I'm seeing a bunch of warnings building the ia64 tree: arch/ia64/kernel/smpboot.c:437: warning: passing argument 2 of 'cpumask_set_cpu' d

[PATCH 06/16] ia64: fix up obsolete cpu function usage.

2015-03-02 Thread Rusty Russell
Thanks to spatch, then a sweep for for_each_cpu_mask => for_each_cpu. Signed-off-by: Rusty Russell Cc: Tony Luck Cc: Fenghua Yu Cc: linux-i...@vger.kernel.org --- arch/ia64/include/asm/acpi.h | 6 +++--- arch/ia64/kernel/acpi.c | 2 +- arch/ia64/kernel/iosapic.c | 2 +- arch/ia64/ker