Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus Logic Madera codecs

2017-04-11 Thread Mark Brown
On Tue, Apr 11, 2017 at 02:20:31PM -0500, Rob Herring wrote: > On Mon, Apr 10, 2017 at 1:11 PM, Mark Brown wrote: > > In what way? Other than the -gpios stuff (which would just be a trivial > > thing if we wanted to change it)? > That's mainly it. I don't see that as meaningful or a good reaso

Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus Logic Madera codecs

2017-04-11 Thread Rob Herring
On Mon, Apr 10, 2017 at 1:11 PM, Mark Brown wrote: > On Mon, Apr 10, 2017 at 12:49:17PM -0500, Rob Herring wrote: > >> Same question as Mark. Should this share bindings with arizona? The >> arizona one looks a bit strange, so not sure we'd want to just copy it. > > In what way? Other than the -gp

Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus Logic Madera codecs

2017-04-10 Thread Mark Brown
On Mon, Apr 10, 2017 at 12:49:17PM -0500, Rob Herring wrote: > Same question as Mark. Should this share bindings with arizona? The > arizona one looks a bit strange, so not sure we'd want to just copy it. In what way? Other than the -gpios stuff (which would just be a trivial thing if we wanted

Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus Logic Madera codecs

2017-04-10 Thread Rob Herring
On Wed, Apr 05, 2017 at 11:07:54AM +0100, Richard Fitzgerald wrote: > This patch adds a driver for the internal LDO1 regulator on > some Cirrus Logic Madera class codecs. > > Signed-off-by: Richard Fitzgerald > Signed-off-by: Charles Keepax > --- > .../devicetree/bindings/regulator/madera-ldo1.

Re: [PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus Logic Madera codecs

2017-04-05 Thread Mark Brown
On Wed, Apr 05, 2017 at 11:07:54AM +0100, Richard Fitzgerald wrote: > This patch adds a driver for the internal LDO1 regulator on > some Cirrus Logic Madera class codecs. There appear to be only data differences to the existing arizona driver, is it possible to share the code? signature.asc Desc

[PATCH 06/16] regulator: madera-ldo1: LDO1 driver for Cirrus Logic Madera codecs

2017-04-05 Thread Richard Fitzgerald
This patch adds a driver for the internal LDO1 regulator on some Cirrus Logic Madera class codecs. Signed-off-by: Richard Fitzgerald Signed-off-by: Charles Keepax --- .../devicetree/bindings/regulator/madera-ldo1.txt | 29 +++ MAINTAINERS| 3 + driver