Re: [PATCH 06/18] software_node: amend software_node_unregister_node_group() to perform unregistration of array in reverse order to be consistent with software_node_unregister_nodes()

2020-12-02 Thread Dan Scally
On 30/11/2020 17:47, Andy Shevchenko wrote: > On Mon, Nov 30, 2020 at 06:17:16PM +0200, Laurent Pinchart wrote: >> Hi Daniel, >> >> Thank you for the patch. >> >> The subject line is very long. We try to keep it within a 72 characters >> limit in the kernel. That can be a challenge sometimes, and

Re: [PATCH 06/18] software_node: amend software_node_unregister_node_group() to perform unregistration of array in reverse order to be consistent with software_node_unregister_nodes()

2020-12-01 Thread Dan Carpenter
Hi Daniel, url: https://github.com/0day-ci/linux/commits/Daniel-Scally/Add-functionality-to-ipu3-cio2-driver-allowing-software_node-connections-to-sensors-on-platforms-designed-for-Windows/20201130-214014 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-m021-20201130

Re: [PATCH 06/18] software_node: amend software_node_unregister_node_group() to perform unregistration of array in reverse order to be consistent with software_node_unregister_nodes()

2020-11-30 Thread Andy Shevchenko
On Mon, Nov 30, 2020 at 06:17:16PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > The subject line is very long. We try to keep it within a 72 characters > limit in the kernel. That can be a challenge sometimes, and expections > can be accepted, but this one is

Re: [PATCH 06/18] software_node: amend software_node_unregister_node_group() to perform unregistration of array in reverse order to be consistent with software_node_unregister_nodes()

2020-11-30 Thread kernel test robot
Hi Daniel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on driver-core/driver-core-testing pm/linux-next v5.10-rc6 next-20201130] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH 06/18] software_node: amend software_node_unregister_node_group() to perform unregistration of array in reverse order to be consistent with software_node_unregister_nodes()

2020-11-30 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. The subject line is very long. We try to keep it within a 72 characters limit in the kernel. That can be a challenge sometimes, and expections can be accepted, but this one is relly long. (The same comment holds for other patches in the series) On Mon,

[PATCH 06/18] software_node: amend software_node_unregister_node_group() to perform unregistration of array in reverse order to be consistent with software_node_unregister_nodes()

2020-11-30 Thread Daniel Scally
To maintain consistency with software_node_unregister_nodes(), reverse the order in which the software_node_unregister_node_group() function unregisters nodes. Suggested-by: Andy Shevchenko Signed-off-by: Daniel Scally --- Changes since v3: Patch introduced drivers/base/swnode.c | 5