Re: [PATCH 06/26] rlimit: Remove unnecessary grab of tasklist_lock

Oleg Nesterov writes: > Hi Eric, > > I'll try very much to read this series tomorrow, can't do this today... > > On 06/06, Eric W. Biederman wrote: >> >> @@ -1380,13 +1380,6 @@ int do_prlimit(struct task_struct *tsk, unsigned int >> resource, >> return

Re: [PATCH 06/26] rlimit: Remove unnecessary grab of tasklist_lock

Oleg Nesterov writes: > Hi Eric, > > I'll try very much to read this series tomorrow, can't do this today... > > On 06/06, Eric W. Biederman wrote: >> >> @@ -1380,13 +1380,6 @@ int do_prlimit(struct task_struct *tsk, unsigned int >> resource, >> return -EPERM; >> } >>

Re: [PATCH 06/26] rlimit: Remove unnecessary grab of tasklist_lock

Hi Eric, I'll try very much to read this series tomorrow, can't do this today... On 06/06, Eric W. Biederman wrote: > > @@ -1380,13 +1380,6 @@ int do_prlimit(struct task_struct *tsk, unsigned int > resource, > return -EPERM; > } > > - /* protect tsk->signal and

Re: [PATCH 06/26] rlimit: Remove unnecessary grab of tasklist_lock

Hi Eric, I'll try very much to read this series tomorrow, can't do this today... On 06/06, Eric W. Biederman wrote: > > @@ -1380,13 +1380,6 @@ int do_prlimit(struct task_struct *tsk, unsigned int > resource, > return -EPERM; > } > > - /* protect tsk->signal and

[PATCH 06/26] rlimit: Remove unnecessary grab of tasklist_lock

There is no reason to take the tasklist lock here. The sighand structure is never referenced and and tsk->signal is guaranteed to stick around until tsk is freed. Further update_rlimit_cpu does not need the tasklist_lock. And the rlim_lock is used to guarantee mutual exclusion. Signed-off-by:

[PATCH 06/26] rlimit: Remove unnecessary grab of tasklist_lock

There is no reason to take the tasklist lock here. The sighand structure is never referenced and and tsk->signal is guaranteed to stick around until tsk is freed. Further update_rlimit_cpu does not need the tasklist_lock. And the rlim_lock is used to guarantee mutual exclusion. Signed-off-by: