Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

2017-04-19 Thread David Howells
Hi Thomas, Thomas Gleixner wrote: > > --- a/drivers/clocksource/cs5535-clockevt.c > > +++ b/drivers/clocksource/cs5535-clockevt.c > > @@ -22,7 +22,7 @@ > > #define DRV_NAME "cs5535-clockevt" > > > > static int timer_irq; > > -module_param_named(irq, timer_irq, int, 0644); > > +module_param_h

Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

2017-04-19 Thread David Howells
Jens Rottmann wrote: > > When the kernel is running in secure boot mode [...] prevent > > access by means of configuring driver modules > > I may easily be wrong, but doesn't secure boot require EFI? For the patches I have, yes. It could feasibly be done by some other mechanism, though I don't

Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

2017-04-18 Thread Jens Rottmann
On 04/15/2017 00:59, David Howells wrote: > When the kernel is running in secure boot mode [...] prevent > access by means of configuring driver modules I may easily be wrong, but doesn't secure boot require EFI? Do secure boot capable systems with old CS5535/36 even exist? Thanks, Jens

Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

2017-04-18 Thread Jens Rottmann
Hi, On 04/14/2017 20:25, Thomas Gleixner wrote: >> static int timer_irq; >> -module_param_named(irq, timer_irq, int, 0644); >> +module_param_hw_named(irq, timer_irq, int, irq, 0644); >> MODULE_PARM_DESC(irq, "Which IRQ to use for the clock source MFGPT ticks."); > > I'm not sure about this. AFA

Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

2017-04-18 Thread Thomas Gleixner
On Tue, 18 Apr 2017, David Howells wrote: > Thomas Gleixner wrote: > > > > > > Btw, is it possible to use IRQ grants to prevent a device that has > > > > > limited > > > > > IRQ options from being drivable? > > > > > > > > What do you mean with 'IRQ grants' ? > > > > > > request_irq(). > > >

Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

2017-04-18 Thread David Howells
Thomas Gleixner wrote: > > > > Btw, is it possible to use IRQ grants to prevent a device that has > > > > limited > > > > IRQ options from being drivable? > > > > > > What do you mean with 'IRQ grants' ? > > > > request_irq(). > > I still can't parse the sentence above. If request_irq() fails

Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

2017-04-15 Thread Thomas Gleixner
On Sat, 15 Apr 2017, David Howells wrote: > Thomas Gleixner wrote: > > > > Btw, is it possible to use IRQ grants to prevent a device that has limited > > > IRQ options from being drivable? > > > > What do you mean with 'IRQ grants' ? > > request_irq(). I still can't parse the sentence above. I

Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

2017-04-14 Thread David Howells
Thomas Gleixner wrote: > > Btw, is it possible to use IRQ grants to prevent a device that has limited > > IRQ options from being drivable? > > What do you mean with 'IRQ grants' ? request_irq(). David

Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

2017-04-14 Thread Thomas Gleixner
On Fri, 14 Apr 2017, David Howells wrote: > Thomas Gleixner wrote: > > > > -module_param_named(irq, timer_irq, int, 0644); > > > +module_param_hw_named(irq, timer_irq, int, irq, 0644); > > > MODULE_PARM_DESC(irq, "Which IRQ to use for the clock source MFGPT > > > ticks."); > > > > I'm not sure

Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

2017-04-14 Thread David Howells
Thomas Gleixner wrote: > > -module_param_named(irq, timer_irq, int, 0644); > > +module_param_hw_named(irq, timer_irq, int, irq, 0644); > > MODULE_PARM_DESC(irq, "Which IRQ to use for the clock source MFGPT > > ticks."); > > I'm not sure about this. AFAIR the parameter is required to work on >

Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

2017-04-14 Thread Thomas Gleixner
On Wed, 5 Apr 2017, David Howells wrote: $subject == crap > When the kernel is running in secure boot mode, we lock down the kernel to > prevent userspace from modifying the running kernel image. Whilst this > includes prohibiting access to things like /dev/mem, it must also prevent > access by

[PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

2017-04-05 Thread David Howells
When the kernel is running in secure boot mode, we lock down the kernel to prevent userspace from modifying the running kernel image. Whilst this includes prohibiting access to things like /dev/mem, it must also prevent access by means of configuring driver modules in such a way as to cause a devi