On 8/28/20 2:45 AM, Vinod Koul wrote:
On 28-08-20, 01:47, Liao, Bard wrote:
snd_pcm_substream *substream,
goto err;
}
- ret = sdw_prepare_stream(dma->stream);
+ /*
+* All cpu dais belong to a stream. To ensure sdw_prepare_stream
+
On 26-08-20, 09:35, Pierre-Louis Bossart wrote:
>
> > > - ret = sdw_prepare_stream(dma->stream);
> > > + /*
> > > + * All cpu dais belong to a stream. To ensure sdw_prepare_stream
> > > + * is called once per stream, we should call it only when
> > > + * dai = first_cpu_dai.
> > > + */
> > >
On 28-08-20, 01:47, Liao, Bard wrote:
> > snd_pcm_substream *substream,
> > > goto err;
> > > }
> > >
> > > - ret = sdw_prepare_stream(dma->stream);
> > > + /*
> > > + * All cpu dais belong to a stream. To ensure sdw_prepare_stream
> > > + * is called once per stream, we
kandaga...@linaro.org; rander.w...@linux.intel.com;
> ranjani.sridha...@linux.intel.com; hui.w...@canonical.com; pierre-
> louis.boss...@linux.intel.com; Kale, Sanyog R ; Lin,
> Mengdong ; Liao, Bard
> Subject: Re: [PATCH 07/11] soundwire: intel: Only call sdw stream APIs for
> the first c
- ret = sdw_prepare_stream(dma->stream);
+ /*
+* All cpu dais belong to a stream. To ensure sdw_prepare_stream
+* is called once per stream, we should call it only when
+* dai = first_cpu_dai.
+*/
+ if (first_cpu_dai == dai)
+ ret
On 18-08-20, 10:41, Bard Liao wrote:
> We should call these APIs once per stream. So we can only call it
> when the dai ops is invoked for the first cpu dai.
>
> Signed-off-by: Bard Liao
> Reviewed-by: Pierre-Louis Bossart
> Reviewed-by: Ranjani Sridharan
> ---
> drivers/soundwire/intel.c |
We should call these APIs once per stream. So we can only call it
when the dai ops is invoked for the first cpu dai.
Signed-off-by: Bard Liao
Reviewed-by: Pierre-Louis Bossart
Reviewed-by: Ranjani Sridharan
---
drivers/soundwire/intel.c | 45 +--
1 file
7 matches
Mail list logo
