Re: [PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-17 Thread Tejun Heo
Hey, Vivek. On Mon, Dec 17, 2012 at 04:49:11PM -0500, Vivek Goyal wrote: > > Eh? Then how would it compete with the children cfqgs? You can > > consider it as the hidden leaf node competing with the children cfqgs, > > right? So, you take the leaf weight and divide it by the total active > >

Re: [PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-17 Thread Vivek Goyal
On Mon, Dec 17, 2012 at 01:33:14PM -0800, Tejun Heo wrote: > Hello, > > On Mon, Dec 17, 2012 at 04:27:36PM -0500, Vivek Goyal wrote: > > What I do care about is atleast being able to read and understand the > > code easily. Right now, it is hard to understand. I am still struggling > > to wrap my

Re: [PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-17 Thread Tejun Heo
Hello, On Mon, Dec 17, 2012 at 04:27:36PM -0500, Vivek Goyal wrote: > What I do care about is atleast being able to read and understand the > code easily. Right now, it is hard to understand. I am still struggling > to wrap my head around it. Hmm... I thought it was really simple. Maybe I'm

Re: [PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-17 Thread Vivek Goyal
On Mon, Dec 17, 2012 at 01:17:38PM -0800, Tejun Heo wrote: > Hello, > > On Mon, Dec 17, 2012 at 03:53:18PM -0500, Vivek Goyal wrote: > > On Fri, Dec 14, 2012 at 02:41:20PM -0800, Tejun Heo wrote: > > > Currently, cfqg charges are scaled directly according to cfqg->weight. > > > Regardless of the

Re: [PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-17 Thread Tejun Heo
Hello, On Mon, Dec 17, 2012 at 03:53:18PM -0500, Vivek Goyal wrote: > On Fri, Dec 14, 2012 at 02:41:20PM -0800, Tejun Heo wrote: > > Currently, cfqg charges are scaled directly according to cfqg->weight. > > Regardless of the number of active cfqgs or the amount of active > > weights, a given

Re: [PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-17 Thread Vivek Goyal
On Fri, Dec 14, 2012 at 02:41:20PM -0800, Tejun Heo wrote: > Currently, cfqg charges are scaled directly according to cfqg->weight. > Regardless of the number of active cfqgs or the amount of active > weights, a given weight value always scales charge the same way. This > works fine as long as

Re: [PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-17 Thread Vivek Goyal
On Fri, Dec 14, 2012 at 02:41:20PM -0800, Tejun Heo wrote: Currently, cfqg charges are scaled directly according to cfqg-weight. Regardless of the number of active cfqgs or the amount of active weights, a given weight value always scales charge the same way. This works fine as long as all

Re: [PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-17 Thread Tejun Heo
Hello, On Mon, Dec 17, 2012 at 03:53:18PM -0500, Vivek Goyal wrote: On Fri, Dec 14, 2012 at 02:41:20PM -0800, Tejun Heo wrote: Currently, cfqg charges are scaled directly according to cfqg-weight. Regardless of the number of active cfqgs or the amount of active weights, a given weight

Re: [PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-17 Thread Vivek Goyal
On Mon, Dec 17, 2012 at 01:17:38PM -0800, Tejun Heo wrote: Hello, On Mon, Dec 17, 2012 at 03:53:18PM -0500, Vivek Goyal wrote: On Fri, Dec 14, 2012 at 02:41:20PM -0800, Tejun Heo wrote: Currently, cfqg charges are scaled directly according to cfqg-weight. Regardless of the number of

Re: [PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-17 Thread Tejun Heo
Hello, On Mon, Dec 17, 2012 at 04:27:36PM -0500, Vivek Goyal wrote: What I do care about is atleast being able to read and understand the code easily. Right now, it is hard to understand. I am still struggling to wrap my head around it. Hmm... I thought it was really simple. Maybe I'm just

Re: [PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-17 Thread Vivek Goyal
On Mon, Dec 17, 2012 at 01:33:14PM -0800, Tejun Heo wrote: Hello, On Mon, Dec 17, 2012 at 04:27:36PM -0500, Vivek Goyal wrote: What I do care about is atleast being able to read and understand the code easily. Right now, it is hard to understand. I am still struggling to wrap my head

Re: [PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-17 Thread Tejun Heo
Hey, Vivek. On Mon, Dec 17, 2012 at 04:49:11PM -0500, Vivek Goyal wrote: Eh? Then how would it compete with the children cfqgs? You can consider it as the hidden leaf node competing with the children cfqgs, right? So, you take the leaf weight and divide it by the total active weight of

[PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-14 Thread Tejun Heo
Currently, cfqg charges are scaled directly according to cfqg->weight. Regardless of the number of active cfqgs or the amount of active weights, a given weight value always scales charge the same way. This works fine as long as all cfqgs are treated equally regardless of their positions in the

[PATCH 07/12] cfq-iosched: implement hierarchy-ready cfq_group charge scaling

2012-12-14 Thread Tejun Heo
Currently, cfqg charges are scaled directly according to cfqg-weight. Regardless of the number of active cfqgs or the amount of active weights, a given weight value always scales charge the same way. This works fine as long as all cfqgs are treated equally regardless of their positions in the