Re: [PATCH 07/13] eeepc-laptop: make disp attribute really write-only

2014-09-15 Thread Frans Klaver
On Mon, Sep 15, 2014 at 01:00:07PM -0700, Darren Hart wrote: > On Sat, Sep 13, 2014 at 01:06:46AM +0200, Frans Klaver wrote: > > The disp attribute is write-only, but sysfs doesn't know this. Currently > > show_sys_acpi() is mimicking sysfs behavior, if the underlying acpi call > > should fail.

Re: [PATCH 07/13] eeepc-laptop: make disp attribute really write-only

2014-09-15 Thread Darren Hart
On Sat, Sep 13, 2014 at 01:06:46AM +0200, Frans Klaver wrote: > The disp attribute is write-only, but sysfs doesn't know this. Currently > show_sys_acpi() is mimicking sysfs behavior, if the underlying acpi call > should fail. This is not ideal; behaving like sysfs is better left to > sysfs. > >

Re: [PATCH 07/13] eeepc-laptop: make disp attribute really write-only

2014-09-15 Thread Darren Hart
On Sat, Sep 13, 2014 at 01:06:46AM +0200, Frans Klaver wrote: The disp attribute is write-only, but sysfs doesn't know this. Currently show_sys_acpi() is mimicking sysfs behavior, if the underlying acpi call should fail. This is not ideal; behaving like sysfs is better left to sysfs.

Re: [PATCH 07/13] eeepc-laptop: make disp attribute really write-only

2014-09-15 Thread Frans Klaver
On Mon, Sep 15, 2014 at 01:00:07PM -0700, Darren Hart wrote: On Sat, Sep 13, 2014 at 01:06:46AM +0200, Frans Klaver wrote: The disp attribute is write-only, but sysfs doesn't know this. Currently show_sys_acpi() is mimicking sysfs behavior, if the underlying acpi call should fail. This is

[PATCH 07/13] eeepc-laptop: make disp attribute really write-only

2014-09-12 Thread Frans Klaver
The disp attribute is write-only, but sysfs doesn't know this. Currently show_sys_acpi() is mimicking sysfs behavior, if the underlying acpi call should fail. This is not ideal; behaving like sysfs is better left to sysfs. Introduce EEEPC_CREATE_DEVICE_ATTR_WO() to instantiate a write-only

[PATCH 07/13] eeepc-laptop: make disp attribute really write-only

2014-09-12 Thread Frans Klaver
The disp attribute is write-only, but sysfs doesn't know this. Currently show_sys_acpi() is mimicking sysfs behavior, if the underlying acpi call should fail. This is not ideal; behaving like sysfs is better left to sysfs. Introduce EEEPC_CREATE_DEVICE_ATTR_WO() to instantiate a write-only