Re: [PATCH 07/13] xfs: allow merging ioends over append boundaries

2019-06-28 Thread Darrick J. Wong
On Fri, Jun 28, 2019 at 07:51:43AM +0200, Christoph Hellwig wrote: > On Thu, Jun 27, 2019 at 11:23:09AM -0700, Darrick J. Wong wrote: > > On Thu, Jun 27, 2019 at 12:48:30PM +0200, Christoph Hellwig wrote: > > > There is no real problem merging ioends that go beyond i_size into an > > > ioend that d

Re: [PATCH 07/13] xfs: allow merging ioends over append boundaries

2019-06-27 Thread Christoph Hellwig
On Thu, Jun 27, 2019 at 11:23:09AM -0700, Darrick J. Wong wrote: > On Thu, Jun 27, 2019 at 12:48:30PM +0200, Christoph Hellwig wrote: > > There is no real problem merging ioends that go beyond i_size into an > > ioend that doesn't. We just need to move the append transaction to the > > base ioend.

Re: [PATCH 07/13] xfs: allow merging ioends over append boundaries

2019-06-27 Thread Darrick J. Wong
On Fri, Jun 28, 2019 at 10:52:04AM +0800, Zorro Lang wrote: > On Thu, Jun 27, 2019 at 09:43:04PM +, Luis Chamberlain wrote: > > On Thu, Jun 27, 2019 at 11:23:09AM -0700, Darrick J. Wong wrote: > > > On Thu, Jun 27, 2019 at 12:48:30PM +0200, Christoph Hellwig wrote: > > > > There is no real prob

Re: [PATCH 07/13] xfs: allow merging ioends over append boundaries

2019-06-27 Thread Zorro Lang
On Thu, Jun 27, 2019 at 09:43:04PM +, Luis Chamberlain wrote: > On Thu, Jun 27, 2019 at 11:23:09AM -0700, Darrick J. Wong wrote: > > On Thu, Jun 27, 2019 at 12:48:30PM +0200, Christoph Hellwig wrote: > > > There is no real problem merging ioends that go beyond i_size into an > > > ioend that do

Re: [PATCH 07/13] xfs: allow merging ioends over append boundaries

2019-06-27 Thread Luis Chamberlain
On Thu, Jun 27, 2019 at 11:23:09AM -0700, Darrick J. Wong wrote: > On Thu, Jun 27, 2019 at 12:48:30PM +0200, Christoph Hellwig wrote: > > There is no real problem merging ioends that go beyond i_size into an > > ioend that doesn't. We just need to move the append transaction to the > > base ioend.

Re: [PATCH 07/13] xfs: allow merging ioends over append boundaries

2019-06-27 Thread Darrick J. Wong
On Thu, Jun 27, 2019 at 12:48:30PM +0200, Christoph Hellwig wrote: > There is no real problem merging ioends that go beyond i_size into an > ioend that doesn't. We just need to move the append transaction to the > base ioend. Also use the opportunity to use a real error code instead > of the magi

[PATCH 07/13] xfs: allow merging ioends over append boundaries

2019-06-27 Thread Christoph Hellwig
There is no real problem merging ioends that go beyond i_size into an ioend that doesn't. We just need to move the append transaction to the base ioend. Also use the opportunity to use a real error code instead of the magic 1 to cancel the transactions, and write a comment explaining the scheme.