Re: [PATCH 07/14] net: sched: use reference counting action init

2018-05-15 Thread Vlad Buslov
On Tue 15 May 2018 at 11:57, Jiri Pirko wrote: > Tue, May 15, 2018 at 01:41:45PM CEST, vla...@mellanox.com wrote: >> >>On Tue 15 May 2018 at 11:39, Jiri Pirko wrote: >>> Tue, May 15, 2018 at 01:32:51PM CEST, vla...@mellanox.com wrote: On Tue 15 May 2018 at 11:24, Jiri Pirko wrote:

Re: [PATCH 07/14] net: sched: use reference counting action init

2018-05-15 Thread Jiri Pirko
Tue, May 15, 2018 at 01:41:45PM CEST, vla...@mellanox.com wrote: > >On Tue 15 May 2018 at 11:39, Jiri Pirko wrote: >> Tue, May 15, 2018 at 01:32:51PM CEST, vla...@mellanox.com wrote: >>> >>>On Tue 15 May 2018 at 11:24, Jiri Pirko wrote: Mon, May 14, 2018 at 04:27:08PM CEST, vla...@mellanox.c

Re: [PATCH 07/14] net: sched: use reference counting action init

2018-05-15 Thread Vlad Buslov
On Tue 15 May 2018 at 11:39, Jiri Pirko wrote: > Tue, May 15, 2018 at 01:32:51PM CEST, vla...@mellanox.com wrote: >> >>On Tue 15 May 2018 at 11:24, Jiri Pirko wrote: >>> Mon, May 14, 2018 at 04:27:08PM CEST, vla...@mellanox.com wrote: Change action API to assume that action init function alw

Re: [PATCH 07/14] net: sched: use reference counting action init

2018-05-15 Thread Jiri Pirko
Tue, May 15, 2018 at 01:32:51PM CEST, vla...@mellanox.com wrote: > >On Tue 15 May 2018 at 11:24, Jiri Pirko wrote: >> Mon, May 14, 2018 at 04:27:08PM CEST, vla...@mellanox.com wrote: >>>Change action API to assume that action init function always takes >>>reference to action, even when overwriting

Re: [PATCH 07/14] net: sched: use reference counting action init

2018-05-15 Thread Vlad Buslov
On Tue 15 May 2018 at 11:24, Jiri Pirko wrote: > Mon, May 14, 2018 at 04:27:08PM CEST, vla...@mellanox.com wrote: >>Change action API to assume that action init function always takes >>reference to action, even when overwriting existing action. This is >>necessary because action API continues to

Re: [PATCH 07/14] net: sched: use reference counting action init

2018-05-15 Thread Jiri Pirko
Mon, May 14, 2018 at 04:27:08PM CEST, vla...@mellanox.com wrote: >Change action API to assume that action init function always takes >reference to action, even when overwriting existing action. This is >necessary because action API continues to use action pointer after init >function is done. At th

[PATCH 07/14] net: sched: use reference counting action init

2018-05-14 Thread Vlad Buslov
Change action API to assume that action init function always takes reference to action, even when overwriting existing action. This is necessary because action API continues to use action pointer after init function is done. At this point action becomes accessible for concurrent modifications so us