Re: [PATCH 07/14] proc/kcore: hide a harmless warning

2017-07-18 Thread Arnd Bergmann
On Tue, Jul 18, 2017 at 10:07 PM, Ard Biesheuvel wrote: > On 18 July 2017 at 21:01, Arnd Bergmann wrote: >> On Tue, Jul 18, 2017 at 9:55 PM, Ard Biesheuvel > > Ah, now it makes sense. I was a bit surprised that > -Wtautological-compare complains about symbolic constants that resolve > to the same

Re: [PATCH 07/14] proc/kcore: hide a harmless warning

2017-07-18 Thread Ard Biesheuvel
On 18 July 2017 at 21:01, Arnd Bergmann wrote: > On Tue, Jul 18, 2017 at 9:55 PM, Ard Biesheuvel > wrote: >> On 18 July 2017 at 20:53, Arnd Bergmann wrote: >>> On Fri, Jul 14, 2017 at 2:28 PM, Ard Biesheuvel >>> wrote: On 14 July 2017 at 10:25, Arnd Bergmann wrote: > gcc warns when MO

Re: [PATCH 07/14] proc/kcore: hide a harmless warning

2017-07-18 Thread Arnd Bergmann
On Tue, Jul 18, 2017 at 9:55 PM, Ard Biesheuvel wrote: > On 18 July 2017 at 20:53, Arnd Bergmann wrote: >> On Fri, Jul 14, 2017 at 2:28 PM, Ard Biesheuvel >> wrote: >>> On 14 July 2017 at 10:25, Arnd Bergmann wrote: gcc warns when MODULES_VADDR/END is defined to the same value as VMAL

Re: [PATCH 07/14] proc/kcore: hide a harmless warning

2017-07-18 Thread Ard Biesheuvel
On 18 July 2017 at 20:53, Arnd Bergmann wrote: > On Fri, Jul 14, 2017 at 2:28 PM, Ard Biesheuvel > wrote: >> On 14 July 2017 at 10:25, Arnd Bergmann wrote: >>> gcc warns when MODULES_VADDR/END is defined to the same value as >>> VMALLOC_START/VMALLOC_END, e.g. on x86-32: >>> >>> fs/proc/kcore.c:

Re: [PATCH 07/14] proc/kcore: hide a harmless warning

2017-07-18 Thread Arnd Bergmann
On Fri, Jul 14, 2017 at 2:28 PM, Ard Biesheuvel wrote: > On 14 July 2017 at 10:25, Arnd Bergmann wrote: >> gcc warns when MODULES_VADDR/END is defined to the same value as >> VMALLOC_START/VMALLOC_END, e.g. on x86-32: >> >> fs/proc/kcore.c: In function ‘add_modules_range’: >> fs/proc/kcore.c:622:

Re: [PATCH 07/14] proc/kcore: hide a harmless warning

2017-07-14 Thread Ard Biesheuvel
On 14 July 2017 at 10:25, Arnd Bergmann wrote: > gcc warns when MODULES_VADDR/END is defined to the same value as > VMALLOC_START/VMALLOC_END, e.g. on x86-32: > > fs/proc/kcore.c: In function ‘add_modules_range’: > fs/proc/kcore.c:622:161: error: self-comparison always evaluates to false > [-Werr

[PATCH 07/14] proc/kcore: hide a harmless warning

2017-07-14 Thread Arnd Bergmann
gcc warns when MODULES_VADDR/END is defined to the same value as VMALLOC_START/VMALLOC_END, e.g. on x86-32: fs/proc/kcore.c: In function ‘add_modules_range’: fs/proc/kcore.c:622:161: error: self-comparison always evaluates to false [-Werror=tautological-compare] if (/*MODULES_VADDR != VMALLOC_S