Re: [PATCH 07/14] pwm: meson: add the meson_pwm_channel data to struct meson_pwm

2019-05-27 Thread Martin Blumenstingl
On Sat, May 25, 2019 at 8:11 PM Martin Blumenstingl wrote: [...] > @@ -509,18 +509,13 @@ static int meson_pwm_probe(struct platform_device *pdev) > meson->chip.dev = >dev; > meson->chip.ops = _pwm_ops; > meson->chip.base = -1; > - meson->chip.npwm = 2; > +

Re: [PATCH 07/14] pwm: meson: add the meson_pwm_channel data to struct meson_pwm

2019-05-27 Thread Neil Armstrong
On 25/05/2019 20:11, Martin Blumenstingl wrote: > Make struct meson_pwm_channel accessible from struct meson_pwm. > > PWM core has a limitation: per-channel data can only be set after > pwmchip_add() is called. However, pwmchip_add() internally calls > pwm_ops.get_state(). If pwm_ops.get_state()

[PATCH 07/14] pwm: meson: add the meson_pwm_channel data to struct meson_pwm

2019-05-25 Thread Martin Blumenstingl
Make struct meson_pwm_channel accessible from struct meson_pwm. PWM core has a limitation: per-channel data can only be set after pwmchip_add() is called. However, pwmchip_add() internally calls pwm_ops.get_state(). If pwm_ops.get_state() needs access to the per-channel data it has to obtain it