Re: [PATCH 07/18] drm/sun4i: tcon: Don't rely on encoders to set the TCON mode

2017-07-20 Thread Maxime Ripard
On Fri, Jul 14, 2017 at 11:56:18AM +0800, Chen-Yu Tsai wrote: > On Thu, Jul 13, 2017 at 10:13 PM, Maxime Ripard > wrote: > > Just like we did for the TCON enable and disable, for historical reasons we > > used to rely on the encoders calling the TCON mode_set function, while the > > CRTC has a cal

Re: [PATCH 07/18] drm/sun4i: tcon: Don't rely on encoders to set the TCON mode

2017-07-13 Thread Chen-Yu Tsai
On Thu, Jul 13, 2017 at 10:13 PM, Maxime Ripard wrote: > Just like we did for the TCON enable and disable, for historical reasons we > used to rely on the encoders calling the TCON mode_set function, while the > CRTC has a callback for that. > > Let's implement it in order to reduce the boilerplat

[PATCH 07/18] drm/sun4i: tcon: Don't rely on encoders to set the TCON mode

2017-07-13 Thread Maxime Ripard
Just like we did for the TCON enable and disable, for historical reasons we used to rely on the encoders calling the TCON mode_set function, while the CRTC has a callback for that. Let's implement it in order to reduce the boilerplate code. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i