Re: [PATCH 07/18] perf hists: Exchange order of comparing items when collapsing hists

2012-12-03 Thread Namhyung Kim
On Mon, 3 Dec 2012 11:19:52 +0100, Jiri Olsa wrote: > On Mon, Dec 03, 2012 at 10:41:08AM +0900, Namhyung Kim wrote: >> On Thu, 29 Nov 2012 15:52:57 -0300, Arnaldo Carvalho de Melo wrote: >> > doesn't this now gets inconsistent with the hist_entry__collapse() call? >> > I.e. iter first, he after,

Re: [PATCH 07/18] perf hists: Exchange order of comparing items when collapsing hists

2012-12-03 Thread Jiri Olsa
On Mon, Dec 03, 2012 at 10:41:08AM +0900, Namhyung Kim wrote: > On Thu, 29 Nov 2012 15:52:57 -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Nov 29, 2012 at 03:38:35PM +0900, Namhyung Kim escreveu: > >> From: Namhyung Kim > >> > >> When comparing entries for collapsing put the given entry

Re: [PATCH 07/18] perf hists: Exchange order of comparing items when collapsing hists

2012-12-03 Thread Jiri Olsa
On Mon, Dec 03, 2012 at 10:41:08AM +0900, Namhyung Kim wrote: On Thu, 29 Nov 2012 15:52:57 -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Nov 29, 2012 at 03:38:35PM +0900, Namhyung Kim escreveu: From: Namhyung Kim namhyung@lge.com When comparing entries for collapsing put the given

Re: [PATCH 07/18] perf hists: Exchange order of comparing items when collapsing hists

2012-12-03 Thread Namhyung Kim
On Mon, 3 Dec 2012 11:19:52 +0100, Jiri Olsa wrote: On Mon, Dec 03, 2012 at 10:41:08AM +0900, Namhyung Kim wrote: On Thu, 29 Nov 2012 15:52:57 -0300, Arnaldo Carvalho de Melo wrote: doesn't this now gets inconsistent with the hist_entry__collapse() call? I.e. iter first, he after, also there

Re: [PATCH 07/18] perf hists: Exchange order of comparing items when collapsing hists

2012-12-02 Thread Namhyung Kim
On Thu, 29 Nov 2012 15:52:57 -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 29, 2012 at 03:38:35PM +0900, Namhyung Kim escreveu: >> From: Namhyung Kim >> >> When comparing entries for collapsing put the given entry first, and >> then the iterated entry. This is for the sake of consistency

Re: [PATCH 07/18] perf hists: Exchange order of comparing items when collapsing hists

2012-12-02 Thread Namhyung Kim
On Thu, 29 Nov 2012 15:52:57 -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Nov 29, 2012 at 03:38:35PM +0900, Namhyung Kim escreveu: From: Namhyung Kim namhyung@lge.com When comparing entries for collapsing put the given entry first, and then the iterated entry. This is for the sake of

Re: [PATCH 07/18] perf hists: Exchange order of comparing items when collapsing hists

2012-11-30 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 29, 2012 at 03:38:35PM +0900, Namhyung Kim escreveu: > From: Namhyung Kim > > When comparing entries for collapsing put the given entry first, and > then the iterated entry. This is for the sake of consistency and will consistency with what? and, see below: > be required by the

Re: [PATCH 07/18] perf hists: Exchange order of comparing items when collapsing hists

2012-11-30 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 29, 2012 at 03:38:35PM +0900, Namhyung Kim escreveu: From: Namhyung Kim namhyung@lge.com When comparing entries for collapsing put the given entry first, and then the iterated entry. This is for the sake of consistency and will consistency with what? and, see below: be

[PATCH 07/18] perf hists: Exchange order of comparing items when collapsing hists

2012-11-28 Thread Namhyung Kim
From: Namhyung Kim When comparing entries for collapsing put the given entry first, and then the iterated entry. This is for the sake of consistency and will be required by the event group report. Cc: Jiri Olsa Cc: Stephane Eranian Signed-off-by: Namhyung Kim --- tools/perf/util/hist.c | 2

[PATCH 07/18] perf hists: Exchange order of comparing items when collapsing hists

2012-11-28 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com When comparing entries for collapsing put the given entry first, and then the iterated entry. This is for the sake of consistency and will be required by the event group report. Cc: Jiri Olsa jo...@redhat.com Cc: Stephane Eranian eran...@google.com