Re: [PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths

2017-11-01 Thread Andy Lutomirski
On Wed, Nov 1, 2017 at 10:25 AM, Brian Gerst wrote: > On Thu, Oct 26, 2017 at 4:26 AM, Andy Lutomirski wrote: >> They did almost the same thing. Remove a bunch of pointless >> instructions (mostly hidden in macros) and reduce cognitive load by >> merging them. >> >> Signed-off-by: Andy Lutomirsk

Re: [PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths

2017-11-01 Thread Thomas Gleixner
On Wed, 1 Nov 2017, Borislav Petkov wrote: > On Wed, Nov 01, 2017 at 04:29:21AM -0700, Andy Lutomirski wrote: > > I'm inclined to leave it. I first wrote it without the long name and > > then I had to re-read the code to make sure I got the register state > > right. The long name serves as docu

Re: [PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths

2017-11-01 Thread Brian Gerst
On Thu, Oct 26, 2017 at 4:26 AM, Andy Lutomirski wrote: > They did almost the same thing. Remove a bunch of pointless > instructions (mostly hidden in macros) and reduce cognitive load by > merging them. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/entry/entry_64.S | 6 +++--- > 1 file c

Re: [PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths

2017-11-01 Thread Borislav Petkov
On Wed, Nov 01, 2017 at 04:29:21AM -0700, Andy Lutomirski wrote: > I'm inclined to leave it. I first wrote it without the long name and > then I had to re-read the code to make sure I got the register state > right. The long name serves as documentation that we need rcx and r11 > to have special

Re: [PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths

2017-11-01 Thread Andy Lutomirski
On Fri, Oct 27, 2017 at 1:11 PM, Borislav Petkov wrote: > On Thu, Oct 26, 2017 at 01:26:39AM -0700, Andy Lutomirski wrote: >> They did almost the same thing. Remove a bunch of pointless >> instructions (mostly hidden in macros) and reduce cognitive load by >> merging them. >> >> Signed-off-by: An

Re: [PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:39AM -0700, Andy Lutomirski wrote: > They did almost the same thing. Remove a bunch of pointless > instructions (mostly hidden in macros) and reduce cognitive load by > merging them. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/entry/entry_64.S | 6 +++--- >

[PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths

2017-10-26 Thread Andy Lutomirski
They did almost the same thing. Remove a bunch of pointless instructions (mostly hidden in macros) and reduce cognitive load by merging them. Signed-off-by: Andy Lutomirski --- arch/x86/entry/entry_64.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/entry/ent