On Fri, 21 Sep 2007 16:39:40 -0700
Dave Hansen <[EMAIL PROTECTED]> wrote:
> On Fri, 2007-09-21 at 16:03 -0700, Andrew Morton wrote:
> > Dave Hansen <[EMAIL PROTECTED]> wrote:
> >
> > > Some ioctl()s can cause writes to the filesystem. Take
> > > these, and make them use mnt_want/drop_write() ins
On Fri, 2007-09-21 at 16:03 -0700, Andrew Morton wrote:
> Dave Hansen <[EMAIL PROTECTED]> wrote:
>
> > Some ioctl()s can cause writes to the filesystem. Take
> > these, and make them use mnt_want/drop_write() instead.
> >
> > We need to pass the filp one layer deeper in XFS, but
> > somebody _ju
On Thu, 20 Sep 2007 12:52:57 -0700
Dave Hansen <[EMAIL PROTECTED]> wrote:
> Some ioctl()s can cause writes to the filesystem. Take
> these, and make them use mnt_want/drop_write() instead.
>
> We need to pass the filp one layer deeper in XFS, but
> somebody _just_ pulled it out in February becau
On Fri, 2007-09-21 at 01:17 -0700, Andrew Morton wrote:
> On Thu, 20 Sep 2007 12:52:57 -0700 Dave Hansen <[EMAIL PROTECTED]> wrote:
>
> > + ret = mnt_want_write(filp->f_vfsmnt);
>
> It still creeps me out that we have this sprinkled *all over* the tree and
> people will forget to do it
On Thu, 20 Sep 2007 12:52:57 -0700 Dave Hansen <[EMAIL PROTECTED]> wrote:
> + ret = mnt_want_write(filp->f_vfsmnt);
It still creeps me out that we have this sprinkled *all over* the tree and
people will forget to do it and there's no runtime or compile-time checking
that they remember
Some ioctl()s can cause writes to the filesystem. Take
these, and make them use mnt_want/drop_write() instead.
We need to pass the filp one layer deeper in XFS, but
somebody _just_ pulled it out in February because nobody
was using it, so I don't feel guilty for adding it back.
Signed-off-by: D
6 matches
Mail list logo
