Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Laurent, On 01/19/2017 12:43 PM, Todor Tomov wrote: > Hi Laurent, > > Thank you for the detailed review. > > On 12/05/2016 05:22 PM, Laurent Pinchart wrote: >> Hi Todor, >> >> Thank you for the patch. >> >> On Friday 25 Nov 2016 16:57:20 Todor Tomov wrote: >>> These files handle the video

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Laurent, On 01/19/2017 12:43 PM, Todor Tomov wrote: > Hi Laurent, > > Thank you for the detailed review. > > On 12/05/2016 05:22 PM, Laurent Pinchart wrote: >> Hi Todor, >> >> Thank you for the patch. >> >> On Friday 25 Nov 2016 16:57:20 Todor Tomov wrote: >>> These files handle the video

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Laurent, Thank you for the detailed review. On 12/05/2016 05:22 PM, Laurent Pinchart wrote: > Hi Todor, > > Thank you for the patch. > > On Friday 25 Nov 2016 16:57:20 Todor Tomov wrote: >> These files handle the video device nodes of the camss driver. > > camss is a quite generic, I'm a

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Laurent, Thank you for the detailed review. On 12/05/2016 05:22 PM, Laurent Pinchart wrote: > Hi Todor, > > Thank you for the patch. > > On Friday 25 Nov 2016 16:57:20 Todor Tomov wrote: >> These files handle the video device nodes of the camss driver. > > camss is a quite generic, I'm a

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Laurent, Hans, On 12/05/2016 05:25 PM, Laurent Pinchart wrote: > Hi Hans, > > On Monday 05 Dec 2016 16:02:55 Hans Verkuil wrote: >> On 12/05/2016 03:45 PM, Laurent Pinchart wrote: >>> On Monday 05 Dec 2016 14:44:55 Hans Verkuil wrote: On 11/25/2016 03:57 PM, Todor Tomov wrote: >

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Laurent, Hans, On 12/05/2016 05:25 PM, Laurent Pinchart wrote: > Hi Hans, > > On Monday 05 Dec 2016 16:02:55 Hans Verkuil wrote: >> On 12/05/2016 03:45 PM, Laurent Pinchart wrote: >>> On Monday 05 Dec 2016 14:44:55 Hans Verkuil wrote: On 11/25/2016 03:57 PM, Todor Tomov wrote: >

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Hans, Thank you for the extensive review. On 12/05/2016 03:44 PM, Hans Verkuil wrote: > A few comments below: > > On 11/25/2016 03:57 PM, Todor Tomov wrote: >> These files handle the video device nodes of the camss driver. >> >> Signed-off-by: Todor Tomov >> --- >>

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Hans, Thank you for the extensive review. On 12/05/2016 03:44 PM, Hans Verkuil wrote: > A few comments below: > > On 11/25/2016 03:57 PM, Todor Tomov wrote: >> These files handle the video device nodes of the camss driver. >> >> Signed-off-by: Todor Tomov >> --- >>

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Hans, On Monday 05 Dec 2016 16:02:55 Hans Verkuil wrote: > On 12/05/2016 03:45 PM, Laurent Pinchart wrote: > > On Monday 05 Dec 2016 14:44:55 Hans Verkuil wrote: > >> On 11/25/2016 03:57 PM, Todor Tomov wrote: > >>> These files handle the video device nodes of the camss driver. > >>> > >>>

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Hans, On Monday 05 Dec 2016 16:02:55 Hans Verkuil wrote: > On 12/05/2016 03:45 PM, Laurent Pinchart wrote: > > On Monday 05 Dec 2016 14:44:55 Hans Verkuil wrote: > >> On 11/25/2016 03:57 PM, Todor Tomov wrote: > >>> These files handle the video device nodes of the camss driver. > >>> > >>>

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Todor, Thank you for the patch. On Friday 25 Nov 2016 16:57:20 Todor Tomov wrote: > These files handle the video device nodes of the camss driver. camss is a quite generic, I'm a bit concerned about claiming that acronym in the global kernel namespace. Would it be too long if we prefixed

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Todor, Thank you for the patch. On Friday 25 Nov 2016 16:57:20 Todor Tomov wrote: > These files handle the video device nodes of the camss driver. camss is a quite generic, I'm a bit concerned about claiming that acronym in the global kernel namespace. Would it be too long if we prefixed

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

On 12/05/2016 03:45 PM, Laurent Pinchart wrote: > Hello, > > On Monday 05 Dec 2016 14:44:55 Hans Verkuil wrote: >> On 11/25/2016 03:57 PM, Todor Tomov wrote: >>> These files handle the video device nodes of the camss driver. >>> >>> Signed-off-by: Todor Tomov >>> --- >>>

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

On 12/05/2016 03:45 PM, Laurent Pinchart wrote: > Hello, > > On Monday 05 Dec 2016 14:44:55 Hans Verkuil wrote: >> On 11/25/2016 03:57 PM, Todor Tomov wrote: >>> These files handle the video device nodes of the camss driver. >>> >>> Signed-off-by: Todor Tomov >>> --- >>> >>>

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hello, On Monday 05 Dec 2016 14:44:55 Hans Verkuil wrote: > On 11/25/2016 03:57 PM, Todor Tomov wrote: > > These files handle the video device nodes of the camss driver. > > > > Signed-off-by: Todor Tomov > > --- > > > > drivers/media/platform/qcom/camss-8x16/video.c |

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hello, On Monday 05 Dec 2016 14:44:55 Hans Verkuil wrote: > On 11/25/2016 03:57 PM, Todor Tomov wrote: > > These files handle the video device nodes of the camss driver. > > > > Signed-off-by: Todor Tomov > > --- > > > > drivers/media/platform/qcom/camss-8x16/video.c | 597

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Hans, On Monday 05 Dec 2016 14:44:55 Hans Verkuil wrote: > > +static int video_querycap(struct file *file, void *fh, > > + struct v4l2_capability *cap) > > +{ > > + strlcpy(cap->driver, "qcom-camss", sizeof(cap->driver)); > > + strlcpy(cap->card, "Qualcomm Camera

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Hans, On Monday 05 Dec 2016 14:44:55 Hans Verkuil wrote: > > +static int video_querycap(struct file *file, void *fh, > > + struct v4l2_capability *cap) > > +{ > > + strlcpy(cap->driver, "qcom-camss", sizeof(cap->driver)); > > + strlcpy(cap->card, "Qualcomm Camera

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

A few comments below: On 11/25/2016 03:57 PM, Todor Tomov wrote: > These files handle the video device nodes of the camss driver. > > Signed-off-by: Todor Tomov > --- > drivers/media/platform/qcom/camss-8x16/video.c | 597 > + >

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

A few comments below: On 11/25/2016 03:57 PM, Todor Tomov wrote: > These files handle the video device nodes of the camss driver. > > Signed-off-by: Todor Tomov > --- > drivers/media/platform/qcom/camss-8x16/video.c | 597 > + >

[PATCH 08/10] media: camss: Add files which handle the video device nodes

These files handle the video device nodes of the camss driver. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/video.c | 597 + drivers/media/platform/qcom/camss-8x16/video.h | 67 +++ 2 files changed, 664 insertions(+)

[PATCH 08/10] media: camss: Add files which handle the video device nodes

These files handle the video device nodes of the camss driver. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/video.c | 597 + drivers/media/platform/qcom/camss-8x16/video.h | 67 +++ 2 files changed, 664 insertions(+) create mode 100644